Skip to content

Commit 64e7653

Browse files
sserrataclaude
andcommitted
fix(cli): pass pluginInstances to getPluginConfig to support non-array plugins (#1246)
Passing the raw `plugins` array to `getPluginConfig` caused a TypeError when `plugins` contained non-array entries (e.g. function plugins), as `data[1]` would be undefined. Since `pluginInstances` is already filtered to only `docusaurus-plugin-openapi-docs` tuples, passing it instead is both correct and safe. Also prevents incorrect matches when another plugin shares the same ID as the openapi-docs plugin. Fixes #1246 Closes #1263 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 0c42d4d commit 64e7653

File tree

1 file changed

+4
-4
lines changed
  • packages/docusaurus-plugin-openapi-docs/src

1 file changed

+4
-4
lines changed

packages/docusaurus-plugin-openapi-docs/src/index.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ custom_edit_url: null
764764
let targetDocsPluginId: any;
765765
if (pluginId) {
766766
try {
767-
const pluginConfig = getPluginConfig(plugins, pluginId);
767+
const pluginConfig = getPluginConfig(pluginInstances, pluginId);
768768
targetConfig = pluginConfig.config ?? {};
769769
targetDocsPluginId = pluginConfig.docsPluginId;
770770
} catch {
@@ -835,7 +835,7 @@ custom_edit_url: null
835835
let targetDocsPluginId: any;
836836
if (pluginId) {
837837
try {
838-
const pluginConfig = getPluginConfig(plugins, pluginId);
838+
const pluginConfig = getPluginConfig(pluginInstances, pluginId);
839839
targetConfig = pluginConfig.config ?? {};
840840
targetDocsPluginId = pluginConfig.docsPluginId;
841841
} catch {
@@ -933,7 +933,7 @@ custom_edit_url: null
933933
let targetConfig: any;
934934
if (pluginId) {
935935
try {
936-
const pluginConfig = getPluginConfig(plugins, pluginId);
936+
const pluginConfig = getPluginConfig(pluginInstances, pluginId);
937937
targetConfig = pluginConfig.config ?? {};
938938
} catch {
939939
console.error(
@@ -992,7 +992,7 @@ custom_edit_url: null
992992
let targetConfig: any;
993993
if (pluginId) {
994994
try {
995-
const pluginConfig = getPluginConfig(plugins, pluginId);
995+
const pluginConfig = getPluginConfig(pluginInstances, pluginId);
996996
targetConfig = pluginConfig.config ?? {};
997997
} catch {
998998
console.error(

0 commit comments

Comments
 (0)