fix(theme): guard against unknown parameter values to prevent crash#1360
Merged
fix(theme): guard against unknown parameter values to prevent crash#1360
Conversation
Parameters with non-OAS3 `in` values (e.g. `formData` from OAS2 specs) would cause a page crash since the params map only keys on the four valid OAS3 locations (path, query, header, cookie). Use optional chaining to skip unknown values gracefully instead of throwing. Fixes #1359 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Size Change: 0 B Total Size: 2.2 MB ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 6c9d7ed): https://docusaurus-openapi-36b86--pr1360-nvx99a8b.web.app (expires Wed, 29 Apr 2026 15:05:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invalues (e.g.formDatacarried over from OAS2/Swagger 2.0 specs) caused a page crash because the params map only defines keys for the four valid OAS3 locations:path,query,header,cookieparamsObject["formData"]returnsundefined, and calling.push()on it throws:can't access property "push", paramsArray is undefinedApiExplorer/Request/index.tsxandApiItem/index.tsxby using optional chaining (?.push) to silently skip unknowninvaluesTest plan
"in": "formData"— page should render instead of crashingpath,query,header,cookie) still populate correctly in the API explorerFixes #1359
🤖 Generated with Claude Code