fix: add React 19 / SSR compatibility guards#1363
Merged
Conversation
- Schema: return null for empty oneOf/anyOf arrays instead of passing zero TabItems to SchemaTabs (which would throw) - SchemaTabs: filter null/undefined children and wrap sanitizeTabsChildren in try-catch; return null if no valid children survive sanitization - MethodEndpoint: early-return a static render during SSR to avoid useSelector running outside a Redux Provider Closes #1130. Partial credit to @stuartbuckell (PR #1257). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Size Change: 0 B Total Size: 2.2 MB ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 5f89b25): https://docusaurus-openapi-36b86--pr1363-klzohos5.web.app (expires Wed, 29 Apr 2026 16:33:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the three approved changes from #1257, dropping the
hooks.tschanges that violated Rules of Hooks.Schema/index.tsx: Returnnullearly whenoneOf/anyOfarray is empty or undefined, preventing zeroTabItems from reachingSchemaTabs.SchemaTabs/index.tsx: Filternull/undefinedchildren before callingsanitizeTabsChildren; wrap it intry-catch; returnnullif no valid children survive. Prevents the "Tabs requires at least one TabItem" crash.MethodEndpoint/index.tsx: Early-return a static (no server URL) render during SSR viaExecutionEnvironment.canUseDOM, preventinguseSelectorfrom running outside a ReduxProviderduring build/hydration.The
hooks.tstry-catch wrappers from the original PR were intentionally excluded — they violate Rules of Hooks and introduce async state whereuseSelectoris synchronous.Related
Test plan
yarn build-packagespasses with no TypeScript errorsnpm run buildin a Docusaurus 3.x project with React 19 no longer throws SSR Redux errorsoneOf: []/anyOf: []no longer crash the build🤖 Generated with Claude Code