fix(terraform): Handle attributes transitioning from plaintext to encrypted (#689)

Author: kklimonda-cl

assets/terraform/test/resource_ike_gateway_test.go

@@ -2,6 +2,7 @@ package provider_test
 
 import (
 	"fmt"
+	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/config"
@@ -322,6 +323,25 @@ func TestAccIkeGateway_ProtocolIkev2(t *testing.T) {
 	})
 }
 
+func TestAccIkeGateway_PlaintextValueMissingRejected(t *testing.T) {
+	nameSuffix := acctest.RandStringFromCharSet(6, acctest.CharSetAlphaNum)
+	prefix := fmt.Sprintf("test-acc-%s", nameSuffix)
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:                 func() { testAccPreCheck(t) },
+		ProtoV6ProviderFactories: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: ikeGatewayConfig_PlaintextValueMissing,
+				ConfigVariables: map[string]config.Variable{
+					"prefix": config.StringVariable(prefix),
+				},
+				ExpectError: regexp.MustCompile(`The attribute at path.+`),
+			},
+		},
+	})
+}
+
 const ikeGatewayConfig_Basic = `
 variable "prefix" { type = string }
 
@@ -760,3 +780,42 @@ resource "panos_template" "example" {
    name     = format("%s-tmpl", var.prefix)
 }
 `
+
+const ikeGatewayConfig_PlaintextValueMissing = `
+variable "prefix" { type = string }
+
+resource "panos_ike_gateway" "example" {
+  location = { template = { name = panos_template.example.name } }
+
+  name    = format("%s-gw1", var.prefix)
+
+  authentication = {
+    pre_shared_key = {
+      key = "[PLAINTEXT-VALUE-MISSING]"
+    }
+  }
+
+  local_address = {
+    interface = panos_ethernet_interface.example.name
+  }
+
+  peer_address = {
+    ip = "10.10.0.1/32"
+  }
+}
+
+resource "panos_ethernet_interface" "example" {
+  location = { template = { name = panos_template.example.name, vsys = "vsys1" } }
+
+  name = "ethernet1/1"
+
+  layer3 = {
+    ips = [{ name = "10.0.0.1/32" }]
+  }
+}
+
+resource "panos_template" "example" {
+   location = { panorama = {} }
+   name     = format("%s-tmpl", var.prefix)
+}
+`

cmd/codegen/main.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"flag"
 	"fmt"
-	"log"
 	"log/slog"
 	"os"
 
@@ -32,13 +31,16 @@ func parseFlags() Config {
 func runCommand(ctx context.Context, cmdType properties.CommandType, cfg string) {
 	cmd, err := codegen.NewCommand(ctx, cmdType, cfg)
 	if err != nil {
-		log.Fatalf("Failed to create command: %s", err)
+		slog.Error("Failed to create command", "error", err)
+		os.Exit(1)
 	}
 	if err := cmd.Setup(); err != nil {
-		log.Fatalf("Setup failed: %s", err)
+		slog.Error("Setup failed", "error", err)
+		os.Exit(1)
 	}
 	if err := cmd.Execute(); err != nil {
-		log.Fatalf("Execution failed: %s", err)
+		slog.Error("Execution failed", "error", err)
+		os.Exit(1)
 	}
 }
 
@@ -62,7 +64,6 @@ func main() {
 	cfg := parseFlags()
 
 	ctx := context.Background()
-	log.SetFlags(log.Ldate | log.Lshortfile)
 
 	// Log the operation type and configuration file being used
 	opTypeMessage := "Operation type: "
@@ -90,5 +91,5 @@ func main() {
 		runCommand(ctx, properties.CommandTypeTerraform, cfg.ConfigFile)
 	}
 
-	log.Println("Generation complete.")
+	slog.Info("Generation complete")
 }