fix: Improve VRF handling to make simpler

Author: adambaumeister

panos/network.py

@@ -547,6 +547,7 @@ def set_logical_router(
             update (bool): Apply the changes to the device (Default: False)
             running_config: If refresh is True, refresh from the running
                 configuration (Default: False)
+            vrf_name (str): Sets the vrf inside the LR. (Default: 'default')
             return_type (str): Specify what this function returns, can be
                 either 'object' (the default) or 'bool'.  If this is 'object',
                 then the return value is the LogicalRouter in question.  If
@@ -570,10 +571,12 @@ def set_logical_router(
             # If the LR isn't found, create it instead
             lr = LogicalRouter(name=lr_name)
             parent.add(lr)
-            vrf = Vrf(name=vrf_name)
-            lr.vrf = [vrf]
             lr.create()
 
+        # Create or locate the VRF
+        vrf = Vrf(name=vrf_name)
+        vrf.refreshall(lr)
+
         # Pass all the vrfs to the update method
         return self._update_reference_in_objects(
             lr,

tests/live/test_network.py

@@ -1755,7 +1755,7 @@ def test_10_set_lr_for_interface(self, fw, state_map):
         """Test setting the LR for an interface instead of the other way around"""
         state = self.sanity(fw, state_map)
         eth: Interface = state.eth_obj_2
-        eth.set_logical_router(state.obj_2, update=True)
+        eth.set_logical_router(state.obj_2.name, update=True)
 
     def update_state_obj(self, fw, state):
         state.obj.ad_static = random.randint(10, 240)