fix: Support moves between LR

Author: adambaumeister

panos/network.py

@@ -562,25 +562,34 @@ def set_logical_router(
             refresh,
             running_config,
             name_only=False,
-            reference_var="interface",
+            reference_var="vrf",
         )
         lr: LogicalRouter | None
 
-        lr = next((lr for lr in all_logical_routers if lr.uid == lr_name), None)
-        if not lr:
+        target_lr = next((lr for lr in all_logical_routers if lr.uid == lr_name), None)
+        if not target_lr:
             # If the LR isn't found, create it instead
-            lr = LogicalRouter(name=lr_name)
-            parent.add(lr)
-            lr.create()
+            target_lr = LogicalRouter(name=lr_name)
+            parent.add(target_lr)
+            vrf = Vrf(name=vrf_name)
+            target_lr.add(vrf)
+            target_lr.create()
+
+        # Remove interface from other LRs first
+        for lr in all_logical_routers:
+            Vrf.refreshall(lr)
+            if lr.name != lr_name:
+                for vrf in lr.findall(Vrf):
+                    if vrf.interface:
+                        if self.name in vrf.interface:
+                            vrf.interface.remove(self.name)
+                            if update:
+                                vrf.update("interface")
 
-        # Create or locate the VRF
-        vrf = Vrf(name=vrf_name)
-        vrf.refreshall(lr)
 
-        # Pass all the vrfs to the update method
         return self._update_reference_in_objects(
-            lr,
-            lr.vrf,
+            target_lr,
+            target_lr.findall(Vrf),
             reference_name=vrf_name,
             reference_var="interface",
             reference_type=Vrf,

tests/live/test_network.py

@@ -1751,12 +1751,27 @@ def setup_state_obj(self, fw, state):
         state.obj.create()
         state.obj_2.create()
 
+        lr_2.refresh()
+        print(f"LR_2 CHILDREN: {lr_2.vrf}")
+
     def test_10_set_lr_for_interface(self, fw, state_map):
         """Test setting the LR for an interface instead of the other way around"""
         state = self.sanity(fw, state_map)
         eth: Interface = state.eth_obj_2
         eth.set_logical_router(state.obj_2.name, update=True)
 
+    def test_11_change_lr_for_interface(self, fw, state_map):
+        """Test setting the LR for an interface instead of the other way around"""
+        state = self.sanity(fw, state_map)
+        eth: Interface = state.eth_obj_2
+        eth.set_logical_router(state.obj.name, update=True, refresh=True)
+
+    def test_11_change_lr_for_interface_add_new_lr(self, fw, state_map):
+        """Test setting the LR for an interface instead of the other way around"""
+        state = self.sanity(fw, state_map)
+        eth: Interface = state.eth_obj
+        eth.set_logical_router("test-new-lr", update=True, refresh=True)
+
     def update_state_obj(self, fw, state):
         state.obj.ad_static = random.randint(10, 240)
         state.obj.ad_rip = random.randint(10, 240)
@@ -1765,6 +1780,7 @@ def cleanup_dependencies(self, fw, state):
         try:
             fw.add(state.obj)
             fw.add(state.obj_2)
+            fw.remove_by_name("test-new-lr", network.LogicalRouter)
             state.obj.delete()
             state.obj_2.delete()
             state.eth_obj.delete()