Skip to content

Feat: Additional ARE Bindings#611

Closed
adambaumeister wants to merge 14 commits into
developfrom
feat/are-lr-bindings
Closed

Feat: Additional ARE Bindings#611
adambaumeister wants to merge 14 commits into
developfrom
feat/are-lr-bindings

Conversation

@adambaumeister

@adambaumeister adambaumeister commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

@adambaumeister adambaumeister changed the base branch from master to develop May 14, 2026 00:09
@adambaumeister adambaumeister force-pushed the feat/are-lr-bindings branch from 2babaf4 to 7286b09 Compare May 14, 2026 00:18
@adambaumeister adambaumeister marked this pull request as ready for review May 15, 2026 04:48
@adambaumeister

Copy link
Copy Markdown
Collaborator Author

Review by Claude Code 🤖

Logic looks correct. The _set_reference refactoring is clean, set_logical_router properly handles cross-LR VRF cleanup via refresh + removal, and the commit response fix in base.py prevents an AttributeError.

One nit: from inspect import trace is unused in test_network.py.

Comment thread panos/network.py Outdated
@adambaumeister

Copy link
Copy Markdown
Collaborator Author

@btorresgil @shinmog any thoughts on this one?

@adambaumeister

Copy link
Copy Markdown
Collaborator Author

Moved to new, cleaner PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interfaces should support logical routers

6 participants