RLP-156282 Fix Crashing CSPM API Pages - add type property to BaseFilterSchema #913
Merged
jrdevore merged 3 commits intoMay 21, 2025
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit f06bb4a): https://pan-dev-f1b58--pr913-fnqwsftt.web.app (expires Fri, 20 Jun 2025 17:03:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9359a9fa100d5fdb082f75280473a90b1f96eb51 |
manukumar6
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Crashing CSPM API Pages
Problem and Fix
The Schema
BaseFilterModeldefines a discriminator with a propertyName oftype.This "property" is not defined with in the
propertiesof the schema. To fix the issue, define thetypeproperty to theBaseFilterSchemaas follows:This is a temporary fix to stop pages from crashing that fail to define the discriminator.
Added to Alerts.json, AssetInventory.json, AssetExplorer.json, and CompliancePosture.json spec files within the properties of
BaseFilterSchemaschema objectCommit message: "RLP-156282 add type property to BaseFilterSchema to fix crashing pages"
Impacted Pages
Types of changes
Checklist