Skip to content

Commit 4bc43b8

Browse files
author
Vincent Potucek
committed
Add CleanupAssertions junit-team#5193 junit-team#5002
- https://docs.openrewrite.org/recipes/java/testing/junit/jupiterbestpractices Signed-off-by: Vincent Potucek <vpotucek@me.com>
1 parent 1a4d544 commit 4bc43b8

2 files changed

Lines changed: 8 additions & 12 deletions

File tree

platform-tests/src/test/java/org/junit/platform/commons/util/ToStringBuilderTests.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,9 @@ void withPrimitiveDoubleArrayField() {
129129
@SuppressWarnings("serial")
130130
void withMapField() {
131131
// @formatter:off
132-
Map<String,Object> map = new LinkedHashMap<>() {{
133-
put("foo", 42);
134-
put("bar", "enigma");
135-
}};
132+
Map<String, Object> map = new LinkedHashMap<>();
133+
map.put("foo", 42);
134+
map.put("bar", "enigma");
136135
// @formatter:on
137136
assertEquals("RoleModel [mystery map = {foo=42, bar=enigma}]",
138137
new ToStringBuilder(new RoleModel()).append("mystery map", map).toString());

platform-tests/src/test/java/org/junit/platform/launcher/core/LauncherDiscoveryResultTests.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,11 @@ void withRetainedEnginesMaintainsOriginalTestEngineRegistrationOrder() {
4141
var engine4 = new DemoEngine("Engine 4");
4242

4343
@SuppressWarnings("serial")
44-
Map<TestEngine, EngineResultInfo> engineResults = new LinkedHashMap<>() {
45-
{
46-
put(engine1, new DemoEngineResultInfo(true));
47-
put(engine2, new DemoEngineResultInfo(false));
48-
put(engine3, new DemoEngineResultInfo(false));
49-
put(engine4, new DemoEngineResultInfo(true));
50-
}
51-
};
44+
Map<TestEngine, EngineResultInfo> engineResults = new LinkedHashMap<>();
45+
engineResults.put(engine1, new DemoEngineResultInfo(true));
46+
engineResults.put(engine2, new DemoEngineResultInfo(false));
47+
engineResults.put(engine3, new DemoEngineResultInfo(false));
48+
engineResults.put(engine4, new DemoEngineResultInfo(true));
5249
assertThat(engineResults.keySet()).containsExactly(engine1, engine2, engine3, engine4);
5350

5451
LauncherDiscoveryResult discoveryResult = new LauncherDiscoveryResult(engineResults, mock(), mock());

0 commit comments

Comments
 (0)