fix old config removal

Author: kennytv

paper-api/src/main/java/org/bukkit/event/world/ClockTimeSkipEvent.java

@@ -4,7 +4,7 @@
 import org.bukkit.event.Event;
 import org.bukkit.event.HandlerList;
 import org.jetbrains.annotations.ApiStatus;
-import org.jetbrains.annotations.NotNull;
+import org.jspecify.annotations.NullMarked;
 
 /**
  * Called when the time skips for a world clock.
@@ -13,6 +13,7 @@
  */
 // TODO - snapshot - 26.1 clock
 @ApiStatus.Experimental
+@NullMarked
 public class ClockTimeSkipEvent extends Event implements Cancellable {
 
     private static final HandlerList HANDLER_LIST = new HandlerList();
@@ -23,7 +24,7 @@ public class ClockTimeSkipEvent extends Event implements Cancellable {
     private boolean cancelled;
 
     @ApiStatus.Internal
-    public ClockTimeSkipEvent(@NotNull SkipReason skipReason, long skipAmount) {
+    public ClockTimeSkipEvent(final SkipReason skipReason, final long skipAmount) {
         this.skipReason = skipReason;
         this.skipAmount = skipAmount;
     }
@@ -33,7 +34,6 @@ public ClockTimeSkipEvent(@NotNull SkipReason skipReason, long skipAmount) {
      *
      * @return a SkipReason value detailing why the time has skipped
      */
-    @NotNull
     public SkipReason getSkipReason() {
         return this.skipReason;
     }
@@ -66,13 +66,11 @@ public void setCancelled(boolean cancel) {
         this.cancelled = cancel;
     }
 
-    @NotNull
     @Override
     public HandlerList getHandlers() {
         return HANDLER_LIST;
     }
 
-    @NotNull
     public static HandlerList getHandlerList() {
         return HANDLER_LIST;
     }

paper-server/patches/sources/net/minecraft/server/commands/TimeCommand.java.patch

@@ -47,7 +47,7 @@
 -        return totalTicks;
 +        ServerClockManager clockManager = source.getLevel().clockManager();
 +        long currentTotalTicks = clockManager.getTotalTicks(clock);
-+        org.bukkit.event.world.ClockTimeSkipEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.callTimeSkipEvent(source, totalTicks - currentTotalTicks);
++        org.bukkit.event.world.ClockTimeSkipEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.createTimeSkipEvent(source, totalTicks - currentTotalTicks);
 +        final long newTotalTicks;
 +        if (event.callEvent()) {
 +            newTotalTicks = currentTotalTicks + event.getSkipAmount();
@@ -63,7 +63,7 @@
 -        ServerClockManager clockManager = source.getServer().clockManager();
 -        clockManager.addTicks(clock, time);
 +        ServerClockManager clockManager = source.getLevel().clockManager();
-+        org.bukkit.event.world.ClockTimeSkipEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.callTimeSkipEvent(source, time);
++        org.bukkit.event.world.ClockTimeSkipEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.createTimeSkipEvent(source, time);
 +        if (event.callEvent()) {
 +            clockManager.addTicks(clock, event.getSkipAmount());
 +        }
@@ -82,7 +82,7 @@
              throw ERROR_NO_TIME_MARKER_FOUND.create(clock.getRegisteredName(), timeMarkerId);
          } else {
 +            final long currentTime = clockManager.getTotalTicks(clock);
-+            final org.bukkit.event.world.ClockTimeSkipEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.callTimeSkipEvent(source, targetTime.getAsLong() - currentTime);
++            final org.bukkit.event.world.ClockTimeSkipEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.createTimeSkipEvent(source, targetTime.getAsLong() - currentTime);
 +            if (event.callEvent()) {
 +                clockManager.setTotalTicks(clock, currentTime + event.getSkipAmount());
 +            }

paper-server/patches/sources/net/minecraft/world/clock/ServerClockManager.java.patch

@@ -4,7 +4,7 @@
      );
      private final PackedClockStates packedClockStates;
      private MinecraftServer server;
-+    private @org.checkerframework.checker.nullness.qual.Nullable ServerLevel level; // Paper - per-world time
++    private @org.jspecify.annotations.Nullable ServerLevel level; // Paper - per-world time
      private final Map<Holder<WorldClock>, ServerClockManager.ClockInstance> clocks = new HashMap<>();
 
      private ServerClockManager(final PackedClockStates packedClockStates) {
@@ -15,7 +15,7 @@
 +        // Paper start - per-world time
 +        this.init(server, null);
 +    }
-+    public void init(final MinecraftServer server, @org.checkerframework.checker.nullness.qual.Nullable final ServerLevel level) {
++    public void init(final MinecraftServer server, @org.jspecify.annotations.Nullable final ServerLevel level) {
 +        this.level = level;
 +        // Paper end - per-world time
          this.server = server;

paper-server/src/main/java/io/papermc/paper/configuration/GlobalConfiguration.java

@@ -30,7 +30,7 @@
 @SuppressWarnings({"CanBeFinal", "FieldCanBeLocal", "FieldMayBeFinal", "NotNullFieldNotInitialized", "InnerClassMayBeStatic"})
 public class GlobalConfiguration extends ConfigurationPart {
     private static final Logger LOGGER = LogUtils.getLogger();
-    static final int CURRENT_VERSION = 32; // (when you change the version, change the comment, so it conflicts on rebases): rename all-worlds time config
+    static final int CURRENT_VERSION = 31; // (when you change the version, change the comment, so it conflicts on rebases): allow-nether property to config
     private static GlobalConfiguration instance;
     public static boolean isFirstStart = false;
     public static GlobalConfiguration get() {

paper-server/src/main/java/io/papermc/paper/configuration/RemovedConfigurations.java

@@ -58,8 +58,7 @@ interface RemovedConfigurations {
         path("misc", "light-queue-size"),
         path("spawn", "keep-spawn-loaded"),
         path("spawn", "keep-spawn-loaded-range"),
-        path("misc", "shield-blocking-delay"),
-        path("command", "time-command-affects-all-worlds")
+        path("misc", "shield-blocking-delay")
     };
 
     NodePath[] REMOVED_GLOBAL_PATHS = {
@@ -88,6 +87,7 @@ interface RemovedConfigurations {
         path("chunk-system", "gen-parallelism"),
         path("logging"), // server is no longer obfuscated since 26.1
         path("unsupported-settings", "compression-format"),
+        path("commands", "time-command-affects-all-worlds") // replaced with time.affects-all-worlds
     };
 
 }

paper-server/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java

@@ -2421,7 +2421,7 @@ public static boolean callPlayerToggleEntityAgeLockEvent(net.minecraft.world.ent
         return true;
     }
 
-    public static ClockTimeSkipEvent callTimeSkipEvent(final CommandSourceStack source, final long skipAmount) {
+    public static ClockTimeSkipEvent createTimeSkipEvent(final CommandSourceStack source, final long skipAmount) {
         if (io.papermc.paper.configuration.GlobalConfiguration.get().time.affectsAllWorlds) {
             return new ClockTimeSkipEvent(ClockTimeSkipEvent.SkipReason.COMMAND, skipAmount);
         }