Add earlier trigger for world migration delay in vanilla logic#13792
Merged
Add earlier trigger for world migration delay in vanilla logic#13792
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts Paper’s startup migration delay so it can be triggered earlier during vanilla/NMS world file fixing, aiming to ensure operators see the backup warning before any upgrade work begins.
Changes:
- Generalizes an attachment error message in
PaperLevelOverrides. - Exposes
WorldFolderMigration.warnAndDelayStartupMigration()and adds a cross-package flag (didInitialLoad) to gate the warning. - Hooks the delay into vanilla
FileFixerUpperand marks initial load completion fromMain.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| paper-server/src/main/java/io/papermc/paper/world/saveddata/PaperLevelOverrides.java | Updates exception message when overrides aren’t attached. |
| paper-server/src/main/java/io/papermc/paper/world/migration/WorldFolderMigration.java | Adds startup gating flag and makes the startup delay/warning callable from NMS. |
| paper-server/patches/sources/net/minecraft/util/filefix/FileFixerUpper.java.patch | Triggers Paper’s startup warning/delay before vanilla file fixing begins. |
| paper-server/patches/sources/net/minecraft/server/Main.java.patch | Sets the initial-load completion flag after the main level data fix path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kennytv
approved these changes
Apr 15, 2026
github-project-automation
Bot
moved this from Awaiting review
to Merged
in Paper PR Queue
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.