Fix loading of plugins from "add-plugin-dir" flag#13810
Open
dan28000 wants to merge 1 commit intoPaperMC:mainfrom
Open
Fix loading of plugins from "add-plugin-dir" flag#13810dan28000 wants to merge 1 commit intoPaperMC:mainfrom
dan28000 wants to merge 1 commit intoPaperMC:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes loading of plugins in a extra plugin directory from this PR #13447.
I've done quick testing on windows with 1.21.11 and 26.1.2-19 and on 1.21.11 it fails to load plugin from extra directory at all and on 26.1.2 it works fine but I had this exact impl since 1.21.1 in my fork (direct link to the patch) there I had 0 issues with it. I'm using it on pterodactyl with shared folder. When testing paper impl on the exact same setup it fails to load nearly all plugins if not all I'm not sure.
I have no issues backporting this to 1.21.11 if anyone would be interested.