Conversation
|
Clocks items are still broken. 2026-04-23_12-08-24.mp4this was tested in a new world, the main world the item works. |
| + | ||
| + public float partialTick(final Holder<WorldClock> definition) { | ||
| + return this.getInstance(definition).partialTick; | ||
| + public ClientboundSetTimePacket createFullSyncPacket(final net.minecraft.server.level.ServerPlayer player) { |
There was a problem hiding this comment.
This need to be marked Nullable, same with packNetworkState with the null player
There was a problem hiding this comment.
The lines were too long so I skipped it 🛏️
They're hardcoded to only work in the overworld level |
|
A resource pack would be needed to make them work in a custom world with a custom item model definition |
|
Last updated for: 6b0abf39c04d5f34ea461255ba923ca35201ada5. Download the Paperclip jar for this pull request: paper-13814.zip Maven PublicationThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven("https://maven-prs.papermc.io/Paper/pr13814") {
name = "Maven for PR #13814" // https://github.com/PaperMC/Paper/pull/13814
mavenContent {
includeModule("io.papermc.paper", "dev-bundle")
includeModule("io.papermc.paper", "paper-api")
}
}
} |
7500434 to
00777fd
Compare
d4bf885 to
094dd2b
Compare
094dd2b to
6b0abf3
Compare
Makes clock managers per-world, given clocks have to be put into client-synchronized registries, which is a big no no and unnecessary block for creating worlds on the fly
Splits TimeSkipEvent into a new ClockTimeSkipEvent for when the new config option is toggled to make clocks global again. the actual clock API will be added separately. the time command succeeds even if the event is cancelled (as before?), but that didn't look like something to waste time on
Tested by creating new worlds / switching worlds with per-player time set and/or paused