Call blocking events on virtual threads#13816
Open
masmc05 wants to merge 1 commit intoPaperMC:mainfrom
Open
Conversation
Owen1212055
approved these changes
Apr 25, 2026
Member
|
I agree 100% with making the config phase use virtual threads, I am not sure about the login event just due to HOW long its been around. However, it seems fair, and would be really nice, |
kennytv
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As briefly mentioned on discord, bukkit currently doesn't have support for proper async events. Currently events where it is recommended to block the thread (like async configuration event in order to wait for a dialog response) will block a platform thread until the plugin is finished/user decided to respond. As an alternative calling those events from virtual threads makes blocking much cheaper.
CONFIGURATION_POOLis currently used for:authenticatorPoolis currently used for:Both have no workload that would require a platform thread, and both benefits from calling the blocking logic in a virtual thread