fix: load dialog Lucide icons from node_modules instead of vendored copy

GhostTypes · GhostTypes · commit 8d3a2abfc21c · 2025-11-03T19:54:14.000-05:00
Update all dialog HTML files to load Lucide directly from node_modules
path instead of the vendored dist/webui/static copy. This resolves the
cross-platform packaging inconsistency where dist/webui was packed into
app.asar on Windows but not on macOS.

Changes:
- Update all 18 dialog HTML files to reference
  ../../../node_modules/lucide/dist/umd/lucide.min.js
- WebUI continues to use vendored copy (lucide.min.js served via HTTP)
- node_modules/.js files are included in asar by default on all platforms

This approach ensures:
- Dialogs load Lucide from consistent location across all platforms
- WebUI maintains independent vendored assets for HTTP serving
- Works in dev mode (node_modules exists) and all packaged builds
- No platform-specific asar packaging differences
diff --git a/src/ui/auto-connect-choice/auto-connect-choice.html b/src/ui/auto-connect-choice/auto-connect-choice.html
@@ -16,7 +16,7 @@
     ">
   <title>Auto-Connect Options</title>
   <link rel="stylesheet" href="auto-connect-choice.css" />
-  <script src="../../../webui/static/lucide.min.js"></script>
+  <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
 </head>
 <body>
 <div class="dialog-container dialog-container--full">
diff --git a/src/ui/component-dialog/component-dialog.html b/src/ui/component-dialog/component-dialog.html
@@ -3,7 +3,7 @@
 <head>
   <meta charset="UTF-8">
   <title>Component Dialog</title>
-  <script src="../../../webui/static/lucide.min.js"></script>
+  <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
   <script>
     if (typeof exports === 'undefined') {
       var exports = {};
diff --git a/src/ui/connect-choice-dialog/connect-choice-dialog.html b/src/ui/connect-choice-dialog/connect-choice-dialog.html
@@ -16,7 +16,7 @@
     ">
     <title>Connect to Printer</title>
     <link rel="stylesheet" href="connect-choice-dialog.css">
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
 </head>
 <body>
     <div class="dialog-container dialog-container--full">
diff --git a/src/ui/ifs-dialog/ifs-dialog.html b/src/ui/ifs-dialog/ifs-dialog.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>IFS - Material Station</title>
     <link rel="stylesheet" href="ifs-dialog.css">
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
         if (typeof exports === 'undefined') {
             var exports = {};
diff --git a/src/ui/input-dialog/input-dialog.html b/src/ui/input-dialog/input-dialog.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>Input Dialog</title>
     <link rel="stylesheet" href="input-dialog.css">
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
         if (typeof exports === 'undefined') {
             var exports = {};
diff --git a/src/ui/job-picker/job-picker.html b/src/ui/job-picker/job-picker.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>Select Job</title>
     <link rel="stylesheet" href="job-picker.css">
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
       if (typeof exports === 'undefined') {
         var exports = {};
diff --git a/src/ui/job-uploader/job-uploader.html b/src/ui/job-uploader/job-uploader.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>Upload Job</title>
     <link rel="stylesheet" href="job-uploader.css" />
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
         if (typeof exports === 'undefined') {
             var exports = {};
diff --git a/src/ui/log-dialog/log-dialog.html b/src/ui/log-dialog/log-dialog.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>Application Logs</title>
     <link rel="stylesheet" href="log-dialog.css" />
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
       if (typeof exports === 'undefined') {
         var exports = {};
diff --git a/src/ui/material-info-dialog/material-info-dialog.html b/src/ui/material-info-dialog/material-info-dialog.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>Material Information</title>
     <link rel="stylesheet" href="material-info-dialog.css">
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
         if (typeof exports === 'undefined') {
             var exports = {};
diff --git a/src/ui/material-matching-dialog/material-matching-dialog.html b/src/ui/material-matching-dialog/material-matching-dialog.html
@@ -6,7 +6,7 @@
   <title>Material Matching</title>
   <link rel="stylesheet" href="../../index.css">
   <link rel="stylesheet" href="material-matching-dialog.css">
-  <script src="../../../webui/static/lucide.min.js"></script>
+  <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
   <script>
     // CommonJS compatibility shim for exports
     if (typeof exports === 'undefined') { var exports = {}; }
diff --git a/src/ui/palette/palette.html b/src/ui/palette/palette.html
@@ -5,7 +5,7 @@
   <meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline'; img-src 'self' data:">
   <title>Component Palette</title>
   <link rel="stylesheet" href="palette.css" />
-  <script src="../../../webui/static/lucide.min.js"></script>
+  <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
   <script>
     if (typeof exports === 'undefined') {
       var exports = {};
diff --git a/src/ui/printer-connected-warning/printer-connected-warning.html b/src/ui/printer-connected-warning/printer-connected-warning.html
@@ -16,7 +16,7 @@
     ">
     <title>Printer Connected</title>
     <link rel="stylesheet" href="printer-connected-warning.css">
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
         if (typeof exports === 'undefined') {
             var exports = {};
diff --git a/src/ui/printer-selection/printer-selection.html b/src/ui/printer-selection/printer-selection.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>Select a Printer</title>
     <link rel="stylesheet" href="printer-selection.css" />
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
         if (typeof exports === 'undefined') {
             var exports = {};
diff --git a/src/ui/send-cmds/send-cmds.html b/src/ui/send-cmds/send-cmds.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>Command Terminal</title>
     <link rel="stylesheet" href="send-cmds.css" />
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
         if (typeof exports === 'undefined') {
             var exports = {};
diff --git a/src/ui/settings/settings.html b/src/ui/settings/settings.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <title>Settings</title>
     <link rel="stylesheet" href="settings.css" />
-    <script src="../../../webui/static/lucide.min.js"></script>
+    <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
     <script>
       if (typeof exports === 'undefined') {
         var exports = {};
diff --git a/src/ui/shortcut-config-dialog/shortcut-config-dialog.html b/src/ui/shortcut-config-dialog/shortcut-config-dialog.html
@@ -5,7 +5,7 @@
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <title>Shortcut Button Configuration</title>
   <link rel="stylesheet" href="shortcut-config-dialog.css">
-  <script src="../../../webui/static/lucide.min.js"></script>
+  <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
 </head>
 <body>
   <div class="dialog-container">
diff --git a/src/ui/single-color-confirmation-dialog/single-color-confirmation-dialog.html b/src/ui/single-color-confirmation-dialog/single-color-confirmation-dialog.html
@@ -6,7 +6,7 @@
   <title>Confirm Print</title>
   <link rel="stylesheet" href="../../index.css">
   <link rel="stylesheet" href="single-color-confirmation-dialog.css">
-  <script src="../../../webui/static/lucide.min.js"></script>
+  <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
   <script>
     // CommonJS compatibility shim for exports
     if (typeof exports === 'undefined') { var exports = {}; }
diff --git a/src/ui/status-dialog/status-dialog.html b/src/ui/status-dialog/status-dialog.html
@@ -4,7 +4,7 @@
   <meta charset="UTF-8" />
   <title>Server Status</title>
   <link rel="stylesheet" href="status-dialog.css" />
-  <script src="../../../webui/static/lucide.min.js"></script>
+  <script src="../../../node_modules/lucide/dist/umd/lucide.min.js"></script>
   <script>
     if (typeof exports === 'undefined') {
       var exports = {};
