Conversation
Member
Author
|
Firedrake tests failing as usual, but this can be merged when you wish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a rare situation when the
MPI_SETUPmethod (setup the subarray view for MPI_READ_ALL) is not called when using MPI : when theRectilinearobject is instantiated first, and the MPI communicator and local slices are given bysetupMPIafter. This requires to read the header again, or else it raises and error.While this is not the recommended usage for
Rectilinear(setupMPIshould be called before instantiating any class), this modification allows it while not changing the overall behavior or performance of the class.