Added workflow for triggering the Codecov bot in PRs#557
Merged
Conversation
Member
|
@jakob-fritz thoughts? |
Collaborator
Your CI-File looks good to me at first glance. |
Contributor
Author
|
What do you mean? Clicking on the codecov badge in the main README will lead you to the report for the commit from 34 minutes ago |
Collaborator
|
Ah ok. It lead me to the report from a week ago, when I tried it just before I wrote my comment. But maybe it was just an issue I had. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do miss the Codecov bot posting about coverage in our PRs. I want to bring it back, but I don't know a lot about it, so maybe this will not actually do the trick.. I cannot test it before since this workflow will only be triggered once it is in the master branch.
What I added here is a separate workflow that runs when the GitHub CI is done and during PRs. All it does in that case is upload the coverage report to Codecov, which I assume will then trigger the bot.
Problem: Coverage will almost certainly be lower than in the master branch because the GPU tests are not included in this report. This should not lead to fluctuations in the coverage report, though, because the report is generated for a non-master branch and therefore does not show up in the tracking.
I suggest we bring back the bot first and when we managed to do that, we configure it to not fail when coverage has decreased. It will still show which parts of the PR are tested and which aren't, which is very useful information.