Skip to content

Commit 38c6a43

Browse files
committed
Fix level 1 sidebar issue
1 parent 7b214fc commit 38c6a43

2 files changed

Lines changed: 5 additions & 29 deletions

File tree

functions/views/_layout.pug

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ html
120120

121121
if user && !user.code
122122
script!= 'window.USER_LEVEL = "' + user.level + '";'
123+
script!= 'window.SIDEBAR_LEVELS = ' + JSON.stringify(user.sidebarLevels) + ';'
123124

124125
for l in user ? user.sidebarLevels : levels
125126
nav(v-show=`user.level == '${l}'`)
@@ -155,15 +156,6 @@ html
155156
p.text-center We’ve updated your level to #[strong #{levelNamesWithAges[user.level]}]. You can always change it on your #[a(href="/account") account settings] page. The first Parallelogram is now available, but officially it is launched in early September. We will be releasing new Parallelograms every week, from mid-September.
156157
button(type="submit" v-on:click="showWelcomeMsg = false") Continue
157158

158-
//- if user
159-
//- .modal(v-if="user.showYearScopeMessage")
160-
//- .modal-background
161-
//- .modal-body
162-
//- h2 Welcome to Parallel!
163-
//- p.text-center(v-if="user.showYearScopeMessage === 1") We don’t yet have Parallelograms maths puzzle sheets for students aged 10 or below, but you might like to try some of the Year 7 Parallelograms, which contains some curious problems.
164-
//- p.text-center(v-if="user.showYearScopeMessage === 2") We don’t yet have Parallelograms maths puzzle sheets for students aged 17 or older, but you might like to try some of the Year 11 Parallelograms, which contains some curious problems.
165-
//- button(type="submit" v-on:click=`user.hideYearScopeMessage()`) Continue
166-
167159
footer
168160
a(href="/about") About
169161
| •

static/scripts/user.js

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ export default function() {
121121
}
122122
});
123123

124-
const cachedLevel = document.cookie.match(/level=(year[7-9])/);
125-
126124
const loginForm = {error: null, reset: false};
127125

128126
const editForm = {loading: false, error: '', teacherCodes: []};
@@ -232,33 +230,19 @@ export default function() {
232230
}
233231
}
234232

235-
let level = cachedLevel ? cachedLevel[1] : (window.USER_LEVEL || 'year6');
233+
const cachedLevel = document.cookie.match(/level=(year[6-9])/);
236234

237-
if (level === 'year5') {
238-
level = 'year6'
239-
}
235+
let level = cachedLevel ? cachedLevel[1] : window.USER_LEVEL;
240236

241-
if (level === 'year12' || level === 'year13') {
242-
level = 'year11'
237+
if(!level || (window.SIDEBAR_LEVELS && !window.SIDEBAR_LEVELS.includes(level))) {
238+
level = 'year6';
243239
}
244240

245-
246-
const hasSeenYearScopeMessage = document.cookie.match(/yearScopeMessageSeen/);
247-
const isTooYoung = window.USER_LEVEL === "year5" || window.USER_LEVEL === "year6";
248-
const isTooOld = window.USER_LEVEL === "year12" || window.USER_LEVEL === "year13";
249-
const showYearScopeMessage = hasSeenYearScopeMessage ? false : isTooYoung ? 1 : isTooOld ? 2 : false;
250-
251241
const user = {
252242
level,
253243
showLogin: false,
254-
showYearScopeMessage,
255244
loginForm, editForm, signupForm, passwordForm, homeEducatorForm,
256245

257-
hideYearScopeMessage() {
258-
user.showYearScopeMessage = false;
259-
document.cookie = `yearScopeMessageSeen=1;path=/;max-age=${60 * 60* 24 * 365}`;
260-
},
261-
262246
setLevel(l) {
263247
user.level = l;
264248
document.cookie = `level=${l};path=/;max-age=${60 * 60* 24 * 365}`;

0 commit comments

Comments
 (0)