Skip to content

Commit 036fa09

Browse files
committed
Fix metadata and exclude depthw from required coord
1 parent 3e02b35 commit 036fa09

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/parcels/convert.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@
2424
if typing.TYPE_CHECKING:
2525
import uxarray as ux
2626

27-
_NEMO_EXPECTED_COORDS = ["glamf", "gphif", "depthw"]
27+
_NEMO_EXPECTED_COORDS = [
28+
"glamf",
29+
"gphif",
30+
] # "depthw" # TODO: Depthw needs to be available if the data has a depth dim. Refactor the whole convert module, this can surely all be handled better.
2831

2932
_NEMO_DIMENSION_COORD_NAMES = [
3033
"x",
@@ -541,7 +544,7 @@ def copernicusmarine_to_sgrid(
541544
sgrid.DimDimPadding("x_center", "lon", sgrid.Padding.LOW),
542545
sgrid.DimDimPadding("y_center", "lat", sgrid.Padding.LOW),
543546
),
544-
vertical_dimensions=(sgrid.DimDimPadding("z_center", "depth", sgrid.Padding.LOW),),
547+
vertical_dimensions=(sgrid.DimDimPadding("depth_center", "depth", sgrid.Padding.LOW),),
545548
).to_attrs(),
546549
)
547550

tests/test_convert.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def test_nemo_to_sgrid():
2323
"node_dimensions": "x y",
2424
"face_dimensions": "x_center:x (padding:low) y_center:y (padding:low)",
2525
"node_coordinates": "lon lat",
26-
"vertical_dimensions": "z_center:depth (padding:high)",
26+
"vertical_dimensions": "depth_center:depth (padding:high)",
2727
}
2828

2929
meta = sgrid.parse_grid_attrs(ds["grid"].attrs)

0 commit comments

Comments
 (0)