Also removing _get_cftime_calendars and _get_cftime_datetimes

Author: erikvansebille

parcels/tools/converters.py

@@ -1,9 +1,7 @@
 from __future__ import annotations
 
-import inspect
 from math import cos, pi
 
-import cftime
 import numpy as np
 import numpy.typing as npt
 
@@ -29,17 +27,6 @@ def convert_to_flat_array(var: npt.ArrayLike) -> npt.NDArray:
     return np.array(var).flatten()
 
 
-def _get_cftime_datetimes() -> list[str]:
-    # Is there a more elegant way to parse these from cftime?
-    cftime_calendars = tuple(x[1].__name__ for x in inspect.getmembers(cftime._cftime, inspect.isclass))
-    cftime_datetime_names = [ca for ca in cftime_calendars if "Datetime" in ca]
-    return cftime_datetime_names
-
-
-def _get_cftime_calendars() -> list[str]:
-    return [getattr(cftime, cf_datetime)(1990, 1, 1).calendar for cf_datetime in _get_cftime_datetimes()]
-
-
 class UnitConverter:
     """Interface class for spatial unit conversion during field sampling that performs no conversion."""
 

tests/test_particlefile.py

@@ -2,7 +2,6 @@
 import tempfile
 from datetime import timedelta
 
-import cftime
 import numpy as np
 import pytest
 import xarray as xr
@@ -17,8 +16,6 @@
     ParticleSet,
     Variable,
 )
-from parcels.particlefile import _set_calendar
-from parcels.tools.converters import _get_cftime_calendars, _get_cftime_datetimes
 from tests.common_kernels import DoNothing
 from tests.utils import create_fieldset_zeros_simple
 
@@ -305,13 +302,6 @@ def SampleP(particle, fieldset, time):  # pragma: no cover
     ds.close()
 
 
-def test_set_calendar():
-    for _calendar_name, cf_datetime in zip(_get_cftime_calendars(), _get_cftime_datetimes(), strict=True):
-        date = getattr(cftime, cf_datetime)(1990, 1, 1)
-        assert _set_calendar(date.calendar) == date.calendar
-    assert _set_calendar("np_datetime64") == "standard"
-
-
 def test_reset_dt(fieldset, tmp_zarrfile):
     # Assert that p.dt gets reset when a write_time is not a multiple of dt
     # for p.dt=0.02 to reach outputdt=0.05 and endtime=0.1, the steps should be [0.2, 0.2, 0.1, 0.2, 0.2, 0.1], resulting in 6 kernel executions