Fixing error_particles test

Author: erikvansebille

parcels/kernel.py

@@ -330,9 +330,8 @@ def execute(self, pset, endtime, dt):
         n_error = pset._num_error_particles
 
         while n_error > 0:
-            error_pset = pset._error_particles
-            # Check for StatusCodes
-            for p in error_pset:
+            for i in pset._error_particles:
+                p = pset[i]
                 if p.state == StatusCode.StopExecution:
                     return
                 if p.state == StatusCode.StopAllExecution:

parcels/particleset.py

@@ -732,15 +732,14 @@ def data_indices(self, variable_name, compare_values, invert=False):
 
     @property
     def _error_particles(self):
-        """Get an iterator over all particles that are in an error state.
+        """Get indices of all particles that are in an error state.
 
         Returns
         -------
-        iterator
-            ParticleDataIterator over error particles.  # TODO update this return
+        indices
+            Indices of error particles.
         """
-        error_indices = self.data_indices("state", [StatusCode.Success, StatusCode.Evaluate], invert=True)
-        return error_indices  # TODO fix to return old ParticleDataIterator(self.particledata, subset=error_indices)
+        return self.data_indices("state", [StatusCode.Success, StatusCode.Evaluate], invert=True)
 
     @property
     def _num_error_particles(self):