Self-review feedback

Author: VeckoTheGecko

tests/test_particlefile.py

@@ -363,7 +363,7 @@ def setup_pset_execute(*, fieldset: FieldSet, outputdt: timedelta, execute_kwarg
         output_file = ParticleFile(name, outputdt=outputdt)
 
         pset.execute(DoNothing, output_file=output_file, **execute_kwargs)
-        df = pd.read_parquet(name)
+        df = utils.read_particlefile(name)
 
     return df
 
@@ -387,8 +387,8 @@ def test_pset_execute_output_time_forwards(fieldset):
     dt = np.timedelta64(5, "m")
 
     df = setup_pset_execute(fieldset=fieldset, outputdt=outputdt, execute_kwargs=dict(runtime=runtime, dt=dt))
-    assert df.time.min() == 0.0
-    assert df.time.max() == runtime / np.timedelta64(1, "s")
+    assert df.time.min() == pd.Timestamp(fieldset.time_interval.left)
+    assert df.time.max() - df.time.min() == runtime
 
 
 def test_pset_execute_outputdt_backwards(fieldset):

tests/utils.py

@@ -17,6 +17,7 @@
 from parcels import FieldSet, Particle, Variable
 from parcels._core.xgrid import _FIELD_DATA_ORDERING, XGrid, get_axis_from_dim_name
 from parcels._datasets.structured.generated import simple_UV_dataset
+from parcels._typing import PathLike
 
 PROJECT_ROOT = Path(__file__).resolve().parents[1]
 TEST_ROOT = PROJECT_ROOT / "tests"
@@ -169,7 +170,9 @@ def assert_cftime_like_particlefile(parquet_path: Path) -> None:
     return
 
 
-def read_particlefile(path: Path, decode_times: bool = True) -> pd.DataFrame:
+def read_particlefile(path: PathLike, decode_times: bool = True) -> pd.DataFrame:
+    path = Path(path)
+
     assert path.suffix == ".parquet", "Only Parquet files are supported"
 
     table = pq.read_table(path)

tests/utils/test_time.py

@@ -224,4 +224,5 @@ def test_timedelta_to_float_exceptions():
 
 @given(datetime_strategy())
 def test_datetime_get_cf_attrs(dt):
-    _get_cf_attrs(dt)
+    attrs = _get_cf_attrs(dt)
+    assert "seconds" in attrs["units"]