Remove from_xarray_dataset_dict

Author: VeckoTheGecko

src/parcels/_datasets/utils.py

@@ -1,4 +1,3 @@
-import copy
 from collections.abc import Hashable
 from typing import Any, Literal, TypeVar
 
@@ -189,23 +188,6 @@ def verbose_print(*args, **kwargs):
     verbose_print("=" * 30 + " End of Comparison " + "=" * 30)
 
 
-def from_xarray_dataset_dict(d) -> xr.Dataset:
-    """Reconstruct a dataset with zero data from the output of ``xarray.Dataset.to_dict(data=False)``.
-
-    Useful in issues helping users debug fieldsets - sharing dataset schemas with associated metadata
-    without sharing the data itself.
-
-    Example
-    -------
-    >>> import xarray as xr
-    >>> from parcels._datasets.structured.generic import datasets
-    >>> ds = datasets['ds_2d_left']
-    >>> d = ds.to_dict(data=False)
-    >>> ds2 = from_xarray_dataset_dict(d)
-    """
-    return xr.Dataset.from_dict(_fill_with_dummy_data(copy.deepcopy(d)))
-
-
 def replace_arrays_with_zeros(
     ds: xr.Dataset, except_for: Literal["coords"] | list[Hashable] | None = None
 ) -> xr.Dataset:

tests/datasets/test_utils.py

@@ -6,18 +6,6 @@
 from parcels._datasets.structured.generic import datasets
 
 
-def test_from_xarray_dataset_dict():
-    ds_expected = datasets["ds_2d_left"]
-    d = ds_expected.to_dict(data=False)
-    ds = utils.from_xarray_dataset_dict(d)
-
-    assert list(ds.coords) == list(ds_expected.coords)
-    assert list(ds.data_vars) == list(ds_expected.data_vars)
-
-    for k in set(ds.coords) | set(ds.data_vars):
-        assert ds[k].attrs == ds_expected[k].attrs, f"Attrs for {k!r} do not match"
-
-
 def _replace_with_cf_time(ds) -> xr.Dataset:
     import cftime
 
@@ -52,11 +40,13 @@ def nonzero_ds():
         },
     )
 
-@pytest.mark.parametrize("ds", [pytest.param(v, id=k) for k,v in datasets.items()])
+
+@pytest.mark.parametrize("ds", [pytest.param(v, id=k) for k, v in datasets.items()])
 @pytest.mark.parametrize("except_for", [None, "coords"])
 def test_replace_arrays_with_zeros(ds, except_for):
     utils.replace_arrays_with_zeros(ds, except_for=except_for)
 
+
 def test_replace_arrays_with_zeros_none(nonzero_ds):
     """except_for=None: all data_vars and coords replaced with zeros."""
     result = utils.replace_arrays_with_zeros(nonzero_ds, except_for=None)