Re-enable SGRID convention setting

VeckoTheGecko · VeckoTheGecko · commit b78de00b3134 · 2026-05-29T14:04:14.000+02:00
diff --git a/src/parcels/_sgrid/core.py b/src/parcels/_sgrid/core.py
@@ -695,7 +695,7 @@ def _attach_sgrid_metadata(ds: xr.Dataset, grid: SGrid2DMetadata | SGrid3DMetada
         0,
         grid.to_attrs(),
     )
-    # ds.attrs["Conventions"] = "SGRID" # TODO: re-enable once XGrid.from_dataset is gone
+    ds.attrs["Conventions"] = "SGRID"
     return ds
 
 

Original file line number	Diff line number	Diff line change
`@@ -695,7 +695,7 @@ def _attach_sgrid_metadata(ds: xr.Dataset, grid: SGrid2DMetadata \| SGrid3DMetada`
`695`	`695`	`0,`
`696`	`696`	`grid.to_attrs(),`
`697`	`697`	`)`
`698`		`- # ds.attrs["Conventions"] = "SGRID" # TODO: re-enable once XGrid.from_dataset is gone`
	`698`	`+ ds.attrs["Conventions"] = "SGRID"`
`699`	`699`	`return ds`
`700`	`700`
`701`	`701`