Commit d29d36b
fix: correct misplaced parentheses in _Spatialslip zeta corrections (#2743)
In the 3D branch of _Spatialslip, the four vertical (zeta) slip corrections
had a misplaced closing parenthesis, e.g.:
is_land(0, 0, 1, 0 & is_land(0, 0, 1, 1) & (zeta > 0))
so the `& is_land(...) & (zeta > 0)` mask meant to gate np.where was instead
swallowed into is_land's 4th positional argument (the x-index). Both the land
test and the zeta position gate were therefore wrong, breaking the vertical
free-/partial-slip boundary correction for 3D C-grid velocities.
Fixed to match the analogous, correctly-formed eta/xsi corrections in the same
function:
is_land(0, 0, 1, 0) & is_land(0, 0, 1, 1) & (zeta > 0)
Existing interpolation and convert tests pass.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>1 parent 5a0df96 commit d29d36b
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
455 | 455 | | |
456 | 456 | | |
457 | 457 | | |
458 | | - | |
| 458 | + | |
459 | 459 | | |
460 | 460 | | |
461 | 461 | | |
462 | 462 | | |
463 | | - | |
| 463 | + | |
464 | 464 | | |
465 | 465 | | |
466 | 466 | | |
467 | 467 | | |
468 | | - | |
| 468 | + | |
469 | 469 | | |
470 | 470 | | |
471 | 471 | | |
472 | 472 | | |
473 | | - | |
| 473 | + | |
474 | 474 | | |
475 | 475 | | |
476 | 476 | | |
| |||
0 commit comments