Migrate to use Pooch for data ingestion and update example data source#1955
Merged
VeckoTheGecko merged 11 commits intov4-devfrom Apr 3, 2025
Merged
Migrate to use Pooch for data ingestion and update example data source#1955VeckoTheGecko merged 11 commits intov4-devfrom
VeckoTheGecko merged 11 commits intov4-devfrom
Conversation
VeckoTheGecko
changed the title
parcels-data repo
VeckoTheGecko
commented
Apr 3, 2025
Comment on lines
+18
to
+29
| # Keys are the dataset names. Values are the filenames in the dataset folder. Note that | ||
| # you can specify subfolders in the dataset folder putting slashes in the filename list. | ||
| # e.g., | ||
| # "my_dataset": ["file0.nc", "folder1/file1.nc", "folder2/file2.nc"] | ||
| # my_dataset/ | ||
| # ├── file0.nc | ||
| # ├── folder1/ | ||
| # │ └── file1.nc | ||
| # └── folder2/ | ||
| # └── file2.nc | ||
| # | ||
| # See instructions at https://github.com/OceanParcels/parcels-data for adding new datasets |
Contributor
Author
There was a problem hiding this comment.
@fluidnumerics-joe are these instructions clear? Do you think you can add your datasets now?
Contributor
Author
|
More info about pooch:
|
erikvansebille
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Migrate to using Pooch for data fetching
Update example data source to repo https://github.com/OceanParcels/parcels-data
Add dev documentation for adding new example datasets
Chose the correct base branch (
v4-devfor v4 changes)Contributes to Test data in unit tests and tutorials #1950
Added tests
Added documentation