2010 generic unstructured dataset#2016
Merged
fluidnumericsJoe merged 4 commits intov4-devfrom Jun 3, 2025
Merged
Conversation
VeckoTheGecko
approved these changes
Jun 3, 2025
Contributor
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good! Happy to merge
Just a note that it may be useful at some point in future to add a time dimension to these datasets (similar to what is done in structured.generic) where we defined T=13 and then do a xr.date_range("2000", "2001", T).
Contributor
Author
|
These do have a time dimension ( At any rate, I see your point. Could you open an issue describing the change you want to see ? That way we can get it knocked out in some of the "finishing/polishing" work and not forget this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfor v3 changes,v4-devfor v4 changes)This PR adds a new unstructured grid generic dataset resembling FESOM. A test has been included in
tests/v4, but it is marked to be skipped since there are some correctness issues in the_search_time_indicesfunction that cause it to fail.