Skip to content

Bugfix unstructured grid search face index - #2087

Merged
VeckoTheGecko merged 1 commit into
v4-devfrom
face-index-fix
Jul 16, 2025
Merged

Bugfix unstructured grid search face index#2087
VeckoTheGecko merged 1 commit into
v4-devfrom
face-index-fix

Conversation

@VeckoTheGecko

@VeckoTheGecko VeckoTheGecko commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Should return the integer, not array of integer

  • Chose the correct base branch (v4-dev for v4 changes)
  • xref Xarray dataset for particledata #2079 (comment)
  • Added tests (no, would be good to flesh out uxgrid searching in tests/v4/test_uxgrid.py perhaps in a seperate PR @fluidnumerics-joe ? How do you want to go about testing here?)

Should return the integer, not array of integer
@VeckoTheGecko
VeckoTheGecko merged commit 488e3fb into v4-dev Jul 16, 2025
9 checks passed
@VeckoTheGecko
VeckoTheGecko deleted the face-index-fix branch July 16, 2025 13:06
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants