Swap out spatialhash query for get_faces_containing_point - #2104
Merged
fluidnumericsJoe merged 5 commits intoJul 28, 2025
Conversation
erikvansebille
approved these changes
Jul 23, 2025
Contributor
Author
|
Ok, I've added the cartesian barycentric coordinates as a backup to the latlon calculation. I'll just add a test with a generic dataset that crosses the antimeridian. This should exercise this new feature. Hopefully just one more commit to get this wrapped up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfor v3 changes,v4-devfor v4 changes)This PR brings in
uxarray.get_faces_containing_pointfor the initial and backup search method to find the face a particle resides in. Additionally, to cope with particles crossing the antimeridian or being in cells that are colinear in lat/lon space, I've added a fallback option for calculating barycentric coordinate in cartesian (x,y,z) space (on a unit sphere). I've added a generic dataset that crosses the antimeridian with tests for particle positions within elements that cross the antimeridian.