Base implementation of Parquet file writing#2583
Draft
VeckoTheGecko wants to merge 13 commits intoParcels-code:mainfrom
Draft
Base implementation of Parquet file writing#2583VeckoTheGecko wants to merge 13 commits intoParcels-code:mainfrom
VeckoTheGecko wants to merge 13 commits intoParcels-code:mainfrom
Conversation
Covered by test_write_dtypes_pfile
VeckoTheGecko
changed the title
VeckoTheGecko
force-pushed
the
push-zlxyoyvlpoqm
branch
from
1d26f4a to
91ce496
Compare
Contributor
Author
|
@erikvansebille let's table some of these questions for our meeting tomorrow (mainly around datetime serialization in the Parquet file) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Parquet file writing to Parcels.
I still need to work on:
test_particlefile.pyfile - are there tests that are no longer needed? What would be the best testing approach here?Posting as draft for initial feedback
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure