Close ParticleFile after encountering kernel errors - #2723
Merged
Conversation
VeckoTheGecko
commented
Jul 6, 2026
Comment on lines
-436
to
+461
| while sign_dt * (time - end_time) < 0: | ||
| if next_output is not None: | ||
| f = min if sign_dt > 0 else max | ||
| next_time = f(next_output, end_time) | ||
| else: | ||
| next_time = end_time | ||
|
|
||
| self._kernel.execute(self, endtime=next_time, dt=dt) | ||
|
|
||
| if next_output is not None: | ||
| if np.abs(next_time - next_output) < 0.001: | ||
| if output_file: | ||
| output_file.write(self, next_output) | ||
| if np.isfinite(outputdt): | ||
| next_output += outputdt * sign_dt | ||
|
|
||
| if verbose_progress: | ||
| pbar.set_description_str( | ||
| "Integration time: " + str(float_to_datelike(time, self.fieldset.time_interval)) | ||
| ) | ||
| pbar.update(sign_dt * (next_time - time)) | ||
|
|
||
| time = next_time | ||
|
|
||
| if output_file is not None: | ||
| output_file.close() | ||
| with output_file if output_file is not None else nullcontext(): | ||
| while sign_dt * (time - end_time) < 0: | ||
| if next_output is not None: | ||
| f = min if sign_dt > 0 else max | ||
| next_time = f(next_output, end_time) | ||
| else: | ||
| next_time = end_time | ||
|
|
||
| self._kernel.execute(self, endtime=next_time, dt=dt) | ||
|
|
||
| if next_output is not None: | ||
| if np.abs(next_time - next_output) < 0.001: | ||
| if output_file: | ||
| output_file.write(self, next_output) | ||
| if np.isfinite(outputdt): | ||
| next_output += outputdt * sign_dt | ||
|
|
||
| if verbose_progress: | ||
| pbar.set_description_str( | ||
| "Integration time: " + str(float_to_datelike(time, self.fieldset.time_interval)) | ||
| ) | ||
| pbar.update(sign_dt * (next_time - time)) | ||
|
|
||
| time = next_time |
Contributor
Author
There was a problem hiding this comment.
Only difference with this block is the indentation and the with statement
VeckoTheGecko
changed the title
VeckoTheGecko
enabled auto-merge (squash)
July 6, 2026 08:33
VeckoTheGecko
force-pushed
the
push-lulsmzmlouvp
branch
from
July 7, 2026 09:49
99ddb03 to
b8f9212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure