Moving relevant v3 tutorials to v4 examples folder#2763
Moving relevant v3 tutorials to v4 examples folder#2763erikvansebille wants to merge 32 commits into
Conversation
as new one will come from @michaeldenes
This also avoids the RuntimeWarning: divide by zero encountered in divide
As not relevant anymore in v4
As discussed with @VeckoTheGecko
|
Should we make a distinction anymore between In a future PR/at the end of this one maybe we should do renamings |
Good point; the distinction between The only 'notebook' that shouldn't run on CI is the homepage_animation one - because it takes approximately 30 minutes just to compute the full set of trajectories. But that's why I now made it a markdown file with code cells that aren't triggered on CI Why shall I not do the renaming to tutorials-* in this PR? |
Doing so in a separate PR or at the end of this one would be good. I'm mid-review at the moment, so doing the renaming right now would mean that I have to resubmit my other review comments. |
VeckoTheGecko
left a comment
There was a problem hiding this comment.
a couple clarifications - happy to merge after those are discussed
| Udims = ["YG", "XC"] | ||
| Vdims = ["YC", "XG"] |
There was a problem hiding this comment.
I think that this change is the wrong way around and should be U=["YC", "XG"]?
- YC -> Y-axis centers
- YG -> Y-axis edges
- XC -> X-axis centers
- XG -> X-axis edges
I don't think its urgent to fix in this PR - perhaps just add a TODO. I'm wondering what the error was that led to this change?
There was a problem hiding this comment.
Now done in 3dfb6f5 |

Description
This PR updates the old tutorials in examples-v3 folder; removing some that are not relevant anymore (e.g. on zarr output) and updating the others to v4 API
Note that, with this PR, we'll likely use more than the 15 minutes of ReadTheDocs build time on their free plan, so we need to think about how to build the documentation...
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None