Swash support#2764
Open
ChitYanToe wants to merge 17 commits into
Open
Conversation
Added the converter function to convert SWASH output files to sgrid data
1. Fixed the SWASH data files download in remote.py 2. Changed the source path of the SWASH files in the tutorial
for more information, see https://pre-commit.ci
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but I'm also keen to get @VeckoTheGecko's review - as I have co-authored much of this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to support SWASH results (matlab files) for Parcels-v4.
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure