Commit 4b3b543
Remove spacetime-region (#264)
* first round, delete SpaceTimeRegion object and related classes/methods
* remove space time region from _plan
* update base and instrument class logic to use waypoint extremes for spacetime domain
* clean up _plan methods
* extend latlon buffer for drifters
* set time buffer from drifter lifetime config
* shift testing to use waypoint space-times instead of space-time-region object
* fix assert error messaging
* remove spatial constraint on fieldset ingestion
* add control over whether to constrain spatial region in fieldset
* give argos a prescribed lifetime
* add lifetime field to expedition models and _plan
* update test with argo lifetime
* remove temporary debugging tools
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* update argo endtime and give depth lim in fieldset generation
* remove depth lim on fieldset generation
* clean up comment
* change lifetime in expedition model to be in days units
* update _plan logic (+ more changes to expedition model) to handle lifetime in minutes
* small refactor for readability
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* remove broken links
* update pre-downloaded data documentation to explain argo/drifter lifetime bounds
* fix docs build?
* another broken link
* add error messaging for unsuported time units
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>1 parent b8a8221 commit 4b3b543
File tree
31 files changed
+337
-652
lines changed- docs/user-guide
- assignments
- documentation
- teacher-content/UU-ocean-of-future
- tutorials
- src/virtualship
- cli
- instruments
- models
- static
- tests
- expedition
- expedition_dir
- instruments
31 files changed
+337
-652
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
154 | | - | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
155 | 156 | | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
156 | 162 | | |
157 | 163 | | |
158 | 164 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
262 | | - | |
| 262 | + | |
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
314 | | - | |
| 314 | + | |
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
| |||
0 commit comments