remove some overlap/duplication of tests

Author: j-atkins

tests/instruments/test_adcp.py

@@ -148,14 +148,6 @@ def test_adcp_sensor_config_active_variables() -> None:
     )
     assert config_with.active_variables() == {"U": "uo", "V": "vo"}
 
-    with pytest.raises(pydantic.ValidationError, match="no enabled sensors"):
-        ADCPConfig(
-            max_depth_meter=-1000.0,
-            num_bins=40,
-            period_minutes=5.0,
-            sensors=[],  # all disabled → invalid
-        )
-
 
 def test_adcp_sensor_config_yaml() -> None:
     """ADCPConfig sensors survive YAML serialisation."""

tests/instruments/test_ctd.py

@@ -191,14 +191,6 @@ def test_ctd_sensor_config_active_variables() -> None:
     )
     assert config_temp_only.active_variables() == {"T": "thetao"}
 
-    with pytest.raises(pydantic.ValidationError, match="no enabled sensors"):
-        CTDConfig(
-            stationkeeping_time_minutes=50,
-            min_depth_meter=-11.0,
-            max_depth_meter=-2000.0,
-            sensors=[],  # all absent = all disabled → invalid
-        )
-
 
 def test_ctd_sensor_config_yaml() -> None:
     """CTDConfig sensors survive YAML serialisation."""

tests/instruments/test_ship_underwater_st.py

@@ -148,12 +148,6 @@ def test_ship_underwater_st_sensor_config_active_variables() -> None:
     )
     assert config_temp_only.active_variables() == {"T": "thetao"}
 
-    with pytest.raises(pydantic.ValidationError, match="no enabled sensors"):
-        ShipUnderwaterSTConfig(
-            period_minutes=5.0,
-            sensors=[],  # all disabled → invalid
-        )
-
 
 def test_ship_underwater_st_sensor_config_yaml() -> None:
     """ShipUnderwaterSTConfig sensors survive YAML serialisation."""

tests/instruments/test_xbt.py

@@ -170,15 +170,6 @@ def test_xbt_sensor_config_active_variables() -> None:
     )
     assert config_with_temp.active_variables() == {"T": "thetao"}
 
-    with pytest.raises(pydantic.ValidationError, match="no enabled sensors"):
-        XBTConfig(
-            min_depth_meter=-2.0,
-            max_depth_meter=-285.0,
-            fall_speed_meter_per_second=6.7,
-            deceleration_coefficient=0.00225,
-            sensors=[],  # all disabled → invalid
-        )
-
 
 def test_xbt_sensor_config_yaml() -> None:
     """XBTConfig sensors survive YAML serialisation."""

tests/test_utils.py

@@ -365,16 +365,9 @@ def test_calc_wp_stationkeeping_time_no_instruments(expedition):
     assert stationkeeping_null == datetime.timedelta(0)  # at least one is 0 time
 
 
-def test_sensor_registry_every_sensor_type_has_entry():
-    """Every SensorType must be present as a key in SENSOR_REGISTRY."""
-    for sensor in SensorType:
-        assert sensor in SENSOR_REGISTRY, f"{sensor} missing from SENSOR_REGISTRY"
-
-
-def test_sensor_registry_no_extra_keys():
-    """SENSOR_REGISTRY should not contain keys outside SensorType."""
-    for key in SENSOR_REGISTRY:
-        assert isinstance(key, SensorType)
+def test_sensor_registry_keys_match_sensor_type():
+    """SENSOR_REGISTRY keys must be exactly the set of SensorType members."""
+    assert set(SENSOR_REGISTRY.keys()) == set(SensorType)
 
 
 @pytest.mark.parametrize(