-
Notifications
You must be signed in to change notification settings - Fork 14
adapt manuscript to new JOSS scope requirements #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -173,9 +173,6 @@ a Creative Commons Attribution 4.0 International License (CC BY | |||||
| Facilities Planning</ext-link> (MFP) tool, giving users the option to | ||||||
| define expedition waypoints via an intuitive web-based mapping | ||||||
| interface.</p> | ||||||
| </sec> | ||||||
| <sec id="functionality"> | ||||||
| <title>Functionality</title> | ||||||
| <p><monospace>VirtualShip</monospace> simulates the deployment of | ||||||
| virtual instruments commonly used in oceanographic fieldwork, with | ||||||
| emphasis on realism in how users plan and execute expeditions. For | ||||||
|
|
@@ -200,6 +197,9 @@ a Creative Commons Attribution 4.0 International License (CC BY | |||||
| et al., 2014</xref>) probes. More detail on each instrument is | ||||||
| available in the | ||||||
| <ext-link ext-link-type="uri" xlink:href="https://virtualship.readthedocs.io/en/latest/user-guide/assignments/Research_proposal_intro.html#Measurement-Options">documentation</ext-link>.</p> | ||||||
| </sec> | ||||||
| <sec id="software-design"> | ||||||
| <title>Software design</title> | ||||||
| <p>The software can simulate complex multidisciplinary expeditions. | ||||||
| One example is a virtual expedition across the Agulhas Current and the | ||||||
| South Eastern Atlantic that deploys a suite of instruments to sample | ||||||
|
|
@@ -257,19 +257,6 @@ a Creative Commons Attribution 4.0 International License (CC BY | |||||
| <p>A full example workflow is outlined in the | ||||||
| <ext-link ext-link-type="uri" xlink:href="https://virtualship.readthedocs.io/en/latest/user-guide/quickstart.html">Quickstart | ||||||
| Guide</ext-link> documentation.</p> | ||||||
| <fig> | ||||||
| <caption><p>Example VirtualShip expedition simulated in July/August | ||||||
| 2023. Expedition waypoints displayed via the MFP tool (a), Underway | ||||||
| ADCP measurements (b), Surface drifter releases (c; 90-day lifetime | ||||||
| per drifter), and CTD vertical profiles for temperature (d) and | ||||||
| oxygen (e). Black triangles in b), d) and e) mark waypoint locations | ||||||
| across the expedition route, corresponding to the purple markers in | ||||||
| a).<styled-content id="figU003Afig1"></styled-content></p></caption> | ||||||
| <graphic mimetype="image" mime-subtype="png" xlink:href="figure1.png" /> | ||||||
| </fig> | ||||||
| </sec> | ||||||
| <sec id="implementation"> | ||||||
| <title>Implementation</title> | ||||||
| <p>Under the hood, <monospace>VirtualShip</monospace> is modular and | ||||||
| extensible. The workflows are designed around | ||||||
| <monospace>Instrument</monospace> base classes and instrument-specific | ||||||
|
|
@@ -299,9 +286,19 @@ a Creative Commons Attribution 4.0 International License (CC BY | |||||
| <ext-link ext-link-type="uri" xlink:href="https://virtualship.readthedocs.io/en/latest/user-guide/documentation/pre_download_data.html">option</ext-link> | ||||||
| for the user to specify local <monospace>NetCDF</monospace> files for | ||||||
| data ingestion, if preferred.</p> | ||||||
| <fig> | ||||||
| <caption><p>Example VirtualShip expedition simulated in July/August | ||||||
| 2023. Expedition waypoints displayed via the MFP tool (a), Underway | ||||||
| ADCP measurements (b), Surface drifter releases (c; 90-day lifetime | ||||||
| per drifter), and CTD vertical profiles for temperature (d) and | ||||||
| oxygen (e). Black triangles in b), d) and e) mark waypoint locations | ||||||
| across the expedition route, corresponding to the purple markers in | ||||||
| a).<styled-content id="figU003Afig1"></styled-content></p></caption> | ||||||
| <graphic mimetype="image" mime-subtype="png" xlink:href="figure1.png" /> | ||||||
| </fig> | ||||||
| </sec> | ||||||
| <sec id="applications-and-future-outlook"> | ||||||
| <title>Applications and future outlook</title> | ||||||
| <sec id="research-impact-statement"> | ||||||
| <title>Research impact statement</title> | ||||||
| <p><monospace>VirtualShip</monospace> has already been extensvely | ||||||
| applied in Master’s teaching settings at Utrecht University as part of | ||||||
| the | ||||||
|
|
@@ -351,6 +348,15 @@ a Creative Commons Attribution 4.0 International License (CC BY | |||||
| capabilities, extensibility and compatability with modern cloud-based | ||||||
| data pipelines.</p> | ||||||
| </sec> | ||||||
| <sec id="ai-usage-disclosure"> | ||||||
| <title>AI usage disclosure</title> | ||||||
| <p>Generative AI technologies (Gemini v2.0/2.5/3.0, ChatGPT | ||||||
| v4o/5.0/5.1/5.2 and GitHub Copilot) were used for code generation, | ||||||
| refactoring and test scaffolding. AI-assisted autocompletion tools | ||||||
| (via GitHub Copilot) were used in the writing of this manuscript. | ||||||
| Authors carefully reviewed and edited all AI-assisted content and made | ||||||
| the core desigin decisions.</p> | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| </sec> | ||||||
| <sec id="acknowledgements"> | ||||||
| <title>Acknowledgements</title> | ||||||
| <p>The VirtualShip project is funded through the Utrecht | ||||||
|
|
||||||
|
erikvansebille marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.