Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 007/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"devDependencies": {
"html-webpack-plugin": "^2.28.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
}
}
2 changes: 1 addition & 1 deletion 008/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"devDependencies": {
"html-webpack-plugin": "^2.28.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
}
}
2 changes: 1 addition & 1 deletion 009/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
"eslint-loader": "^1.7.1",
"html-webpack-plugin": "^2.28.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
}
}
2 changes: 1 addition & 1 deletion 011/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"html-webpack-plugin": "^2.28.0",
"style-loader": "^0.17.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
}
}
2 changes: 1 addition & 1 deletion 013/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"html-webpack-plugin": "^2.28.0",
"style-loader": "^0.17.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
}
}
2 changes: 1 addition & 1 deletion 015/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"html-webpack-plugin": "^2.28.0",
"style-loader": "^0.17.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
}
}
2 changes: 1 addition & 1 deletion 016/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"html-webpack-plugin": "^2.28.0",
"style-loader": "^0.17.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
}
}
2 changes: 1 addition & 1 deletion 017/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"html-webpack-plugin": "^2.28.0",
"style-loader": "^0.17.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The webpack-dev-server dependency is being updated to ^5.2.2, which is incompatible with the project's existing webpack version ^2.3.2, causing the development server to crash.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The pull request updates webpack-dev-server to version ^5.2.2 while leaving the core webpack dependency at ^2.3.2. According to official documentation, webpack-dev-server version 5 and higher requires webpack version 5.0.0 or greater as a peer dependency. This version mismatch will cause the development server to fail immediately upon startup when npm start is executed. The server will crash because it will attempt to use webpack v5 APIs that are not present in the installed webpack v2.3.2. This issue affects all projects updated in this PR, rendering their development environments unusable.

💡 Suggested Fix

To resolve the incompatibility, the webpack dependency should be upgraded to a version compatible with webpack-dev-server v5, such as ^5.0.0 or higher. This will likely require further changes to the webpack configuration files to account for breaking changes between webpack v2 and v5, such as replacing the deprecated CommonsChunkPlugin.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: 017/package.json#L24

Potential issue: The pull request updates `webpack-dev-server` to version `^5.2.2` while
leaving the core `webpack` dependency at `^2.3.2`. According to official documentation,
`webpack-dev-server` version 5 and higher requires `webpack` version 5.0.0 or greater as
a peer dependency. This version mismatch will cause the development server to fail
immediately upon startup when `npm start` is executed. The server will crash because it
will attempt to use webpack v5 APIs that are not present in the installed webpack
v2.3.2. This issue affects all projects updated in this PR, rendering their development
environments unusable.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8160339

},
"dependencies": {
"react": "^15.6.0"
Expand Down
2 changes: 1 addition & 1 deletion 018/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"html-webpack-plugin": "^2.28.0",
"style-loader": "^0.17.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
},
"dependencies": {
"react": "^15.6.0"
Expand Down
2 changes: 1 addition & 1 deletion 019/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"html-webpack-plugin": "^2.28.0",
"style-loader": "^0.17.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
},
"dependencies": {
"react": "^15.6.0"
Expand Down
2 changes: 1 addition & 1 deletion 020/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"html-webpack-plugin": "^2.28.0",
"style-loader": "^0.17.0",
"webpack": "^2.3.2",
"webpack-dev-server": "^2.4.2"
"webpack-dev-server": "^5.2.2"
},
"dependencies": {
"react": "^15.6.0"
Expand Down