Skip to content

Commit 368dd14

Browse files
committed
Allow to add selectors to ai model selects and only show models supporting structured output for AI extractor
1 parent 9d38930 commit 368dd14

3 files changed

Lines changed: 47 additions & 22 deletions

File tree

src/Controller/TypeaheadController.php

Lines changed: 34 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -22,37 +22,37 @@
2222

2323
namespace App\Controller;
2424

25-
use App\Entity\Parameters\AbstractParameter;
26-
use App\Services\AI\AIPlatformRegistry;
27-
use App\Services\AI\AIPlatforms;
28-
use App\Settings\MiscSettings\IpnSuggestSettings;
29-
use Symfony\Component\Cache\Adapter\AdapterInterface;
30-
use Symfony\Component\HttpFoundation\Response;
3125
use App\Entity\Attachments\Attachment;
32-
use App\Entity\Parts\Category;
33-
use App\Entity\Parts\Footprint;
26+
use App\Entity\Parameters\AbstractParameter;
3427
use App\Entity\Parameters\AttachmentTypeParameter;
3528
use App\Entity\Parameters\CategoryParameter;
36-
use App\Entity\Parameters\ProjectParameter;
3729
use App\Entity\Parameters\FootprintParameter;
3830
use App\Entity\Parameters\GroupParameter;
3931
use App\Entity\Parameters\ManufacturerParameter;
4032
use App\Entity\Parameters\MeasurementUnitParameter;
4133
use App\Entity\Parameters\PartParameter;
34+
use App\Entity\Parameters\ProjectParameter;
4235
use App\Entity\Parameters\StorageLocationParameter;
4336
use App\Entity\Parameters\SupplierParameter;
37+
use App\Entity\Parts\Category;
38+
use App\Entity\Parts\Footprint;
4439
use App\Entity\Parts\Part;
4540
use App\Entity\PriceInformations\Currency;
4641
use App\Repository\ParameterRepository;
42+
use App\Services\AI\AIPlatformRegistry;
43+
use App\Services\AI\AIPlatforms;
4744
use App\Services\Attachments\AttachmentURLGenerator;
4845
use App\Services\Attachments\BuiltinAttachmentsFinder;
4946
use App\Services\Attachments\PartPreviewGenerator;
5047
use App\Services\Tools\TagFinder;
48+
use App\Settings\MiscSettings\IpnSuggestSettings;
5149
use Doctrine\ORM\EntityManagerInterface;
50+
use Symfony\AI\Platform\Capability;
5251
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
5352
use Symfony\Component\Asset\Packages;
5453
use Symfony\Component\HttpFoundation\JsonResponse;
5554
use Symfony\Component\HttpFoundation\Request;
55+
use Symfony\Component\HttpFoundation\Response;
5656
use Symfony\Component\Routing\Attribute\Route;
5757
use Symfony\Component\Serializer\Encoder\JsonEncoder;
5858
use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
@@ -126,9 +126,12 @@ private function typeToParameterClass(string $type): string
126126
}
127127

128128
#[Route(path: '/parts/search/{query}', name: 'typeahead_parts')]
129-
public function parts(EntityManagerInterface $entityManager, PartPreviewGenerator $previewGenerator,
130-
AttachmentURLGenerator $attachmentURLGenerator, string $query = ""): JsonResponse
131-
{
129+
public function parts(
130+
EntityManagerInterface $entityManager,
131+
PartPreviewGenerator $previewGenerator,
132+
AttachmentURLGenerator $attachmentURLGenerator,
133+
string $query = ""
134+
): JsonResponse {
132135
$this->denyAccessUnlessGranted('@parts.read');
133136

134137
$repo = $entityManager->getRepository(Part::class);
@@ -139,7 +142,7 @@ public function parts(EntityManagerInterface $entityManager, PartPreviewGenerato
139142
foreach ($parts as $part) {
140143
//Determine the picture to show:
141144
$preview_attachment = $previewGenerator->getTablePreviewAttachment($part);
142-
if($preview_attachment instanceof Attachment) {
145+
if ($preview_attachment instanceof Attachment) {
143146
$preview_url = $attachmentURLGenerator->getThumbnailURL($preview_attachment, 'thumbnail_sm');
144147
} else {
145148
$preview_url = '';
@@ -153,7 +156,7 @@ public function parts(EntityManagerInterface $entityManager, PartPreviewGenerato
153156
'footprint' => $part->getFootprint() instanceof Footprint ? $part->getFootprint()->getName() : '',
154157
'description' => mb_strimwidth($part->getDescription(), 0, 127, '...'),
155158
'image' => $preview_url,
156-
];
159+
];
157160
}
158161

159162
return new JsonResponse($data);
@@ -224,24 +227,35 @@ public function ipnSuggestions(
224227

225228

226229
$partRepository = $entityManager->getRepository(Part::class);
227-
$ipnSuggestions = $partRepository->autoCompleteIpn($clonedPart, $description, $this->ipnSuggestSettings->suggestPartDigits);
230+
$ipnSuggestions = $partRepository->autoCompleteIpn($clonedPart, $description,
231+
$this->ipnSuggestSettings->suggestPartDigits);
228232

229233
return new JsonResponse($ipnSuggestions);
230234
}
231235

232236
#[Route(path: '/ai/{platform}/models', name: 'typeahead_ai_models', requirements: ['platform' => '.+'])]
233237
public function aiModels(
234238
AIPlatforms $platform,
239+
Request $request,
235240
AIPlatformRegistry $platformRegistry,
236241
CacheInterface $cache,
237242
): JsonResponse {
238-
239243
$this->denyAccessUnlessGranted('@config.change_system_settings');
240244

241-
$models = $cache->get('ai_models_'.$platform->value, function(ItemInterface $item) use ($platformRegistry, $platform) {
242-
$item->expiresAfter(3600); //Cache for 1 hour
243-
return $platformRegistry->getPlatform($platform)->getModelCatalog()->getModels();
244-
});
245+
$capability_filter = $request->query->getEnum('capability', Capability::class);
246+
247+
$models = $cache->get('ai_models_'.$platform->value.'_'.($capability_filter?->value ?? 'all'),
248+
function (ItemInterface $item) use ($platformRegistry, $platform, $capability_filter) {
249+
$item->expiresAfter(3600); //Cache for 1 hour
250+
if ($capability_filter === null) {
251+
return $platformRegistry->getPlatform($platform)->getModelCatalog()->getModels();
252+
}
253+
254+
//Otherwise filter the models by the capability
255+
return array_filter($platformRegistry->getPlatform($platform)->getModelCatalog()->getModels(),
256+
static fn(array $model) => in_array($capability_filter, $model['capabilities'] ?? [], true)
257+
);
258+
});
245259

246260
return new JsonResponse($models);
247261
}

src/Form/Settings/AiModelsType.php

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
namespace App\Form\Settings;
2525

26+
use Symfony\AI\Platform\Capability;
2627
use Symfony\Component\Form\AbstractType;
2728
use Symfony\Component\Form\Extension\Core\Type\TextType;
2829
use Symfony\Component\Form\FormInterface;
@@ -50,11 +51,20 @@ public function configureOptions(OptionsResolver $resolver): void
5051
//The target label of the platform select, which is used to filter the models for the selected platform.
5152
$resolver->setRequired('platform_selector');
5253
$resolver->setAllowedTypes('platform_selector', 'string');
54+
55+
//Only show models, that have the given capability. This is used to only show models that support structured output for the AI extractor settings.
56+
$resolver->setDefault('filter_capability', null);
57+
$resolver->setAllowedTypes('filter_capability', ['null', Capability::class]);
5358
}
5459

5560
public function finishView(FormView $view, FormInterface $form, array $options): void
5661
{
57-
$view->vars['attr']['data-url-template'] = $this->urlGenerator->generate('typeahead_ai_models', ['platform' => '__PLATFORM__']);
62+
$urlOptions = ['platform' => '__PLATFORM__'];
63+
if ($options['filter_capability'] !== null) {
64+
$urlOptions['capability'] = $options['filter_capability']->value;
65+
}
66+
67+
$view->vars['attr']['data-url-template'] = $this->urlGenerator->generate('typeahead_ai_models', $urlOptions);
5868
$view->vars['attr']['data-controller'] = 'elements--ai-model-autocomplete';
5969

6070
$view->vars['attr']['data-platform-selector'] = $options['platform_selector'];

src/Settings/InfoProviderSystem/AIExtractorSettings.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
use Jbtronics\SettingsBundle\Settings\Settings;
3232
use Jbtronics\SettingsBundle\Settings\SettingsParameter;
3333
use Jbtronics\SettingsBundle\Settings\SettingsTrait;
34+
use Symfony\AI\Platform\Capability;
3435
use Symfony\Component\Translation\TranslatableMessage as TM;
3536

3637
#[Settings(name: "ai_extractor", label: new TM("settings.ips.ai_extractor"), description: new TM("settings.ips.ai_extractor.description"))]
@@ -48,7 +49,7 @@ class AIExtractorSettings
4849
public ?AIPlatforms $platform = null;
4950

5051
#[SettingsParameter(label: new TM("settings.ips.ai_extractor.model"), description: new TM("settings.ips.ai_extractor.model.description"),
51-
formType: AiModelsType::class, formOptions: ['platform_selector' => self::MODEL_SELECTOR_LABEL],
52+
formType: AiModelsType::class, formOptions: ['platform_selector' => self::MODEL_SELECTOR_LABEL, 'filter_capability' => Capability::OUTPUT_STRUCTURED],
5253
envVar: "string:PROVIDER_AI_EXTRACTOR_MODEL", envVarMode: EnvVarMode::OVERWRITE
5354
)]
5455
public string $model = 'z-ai/glm-4.7';

0 commit comments

Comments
 (0)