Skip to content

Commit 83608ff

Browse files
committed
Do not scroll up the sidebar when clicking on a treeview
1 parent 78b1d41 commit 83608ff

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

assets/controllers/elements/sidebar_tree_controller.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ export default class extends TreeController {
4040
//Check if we have a saved mode
4141
const stored_mode = localStorage.getItem(this._storage_key);
4242

43+
this._frame = this.element.dataset.frame || "content"; //By default, navigate in the content frame, if a frame is defined
44+
4345
//Use stored mode if possible, otherwise use default
4446
if(stored_mode) {
4547
try {

assets/controllers/elements/tree_controller.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ export default class extends Controller {
3939
*/
4040
_tree = null;
4141

42+
_frame = "frame";
43+
4244
connect() {
4345
const treeElement = this.treeTarget;
4446
if (!treeElement) {
@@ -48,6 +50,7 @@ export default class extends Controller {
4850

4951
this._url = this.element.dataset.treeUrl;
5052
this._data = this.element.dataset.treeData;
53+
this._frame = this.element.dataset.frame || "content"; //By default, navigate in the content frame, if a frame is defined
5154

5255
if(this.element.dataset.treeShowTags === "true") {
5356
this._showTags = true;
@@ -99,7 +102,7 @@ export default class extends Controller {
99102
onNodeSelected: (event) => {
100103
const node = event.detail.node;
101104
if (node.href) {
102-
window.Turbo.visit(node.href, {action: "advance"});
105+
window.Turbo.visit(node.href, {action: "advance", frame: this._frame});
103106
this._registerURLWatcher(node);
104107
}
105108
},
@@ -198,4 +201,4 @@ export default class extends Controller {
198201
return myResolve(this._data);
199202
});
200203
}
201-
}
204+
}

0 commit comments

Comments
 (0)