Skip to content

Feature/add xlsx support#981

Closed
barisgit wants to merge 7 commits intoPart-DB:masterfrom
barisgit:feature/add-xlsx-support
Closed

Feature/add xlsx support#981
barisgit wants to merge 7 commits intoPart-DB:masterfrom
barisgit:feature/add-xlsx-support

Conversation

@barisgit
Copy link
Copy Markdown
Contributor

@barisgit barisgit commented Aug 1, 2025

  • Allow using xlsx and xls to import parts
  • Update example csv to better show what is possible
  • Add required tests (PASS)
  • Fix parts merger when using update from info supplier and consider parts that already have a spn populated

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 77.50000% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.08%. Comparing base (8b417d6) to head (bbe4b01).
⚠️ Report is 322 commits behind head on master.

Files with missing lines Patch % Lines
src/Services/EntityMergers/Mergers/PartMerger.php 5.00% 19 Missing ⚠️
src/Services/ImportExportSystem/EntityImporter.php 83.52% 14 Missing ⚠️
src/Services/ImportExportSystem/EntityExporter.php 94.23% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #981      +/-   ##
============================================
+ Coverage     59.83%   60.08%   +0.25%     
- Complexity     6050     6067      +17     
============================================
  Files           529      529              
  Lines         20625    20748     +123     
============================================
+ Hits          12341    12467     +126     
+ Misses         8284     8281       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@barisgit
Copy link
Copy Markdown
Contributor Author

barisgit commented Sep 9, 2025

@jbtronics This PR can be closed right?

@jbtronics
Copy link
Copy Markdown
Member

If everything is contained in the other pr, then yes

@barisgit
Copy link
Copy Markdown
Contributor Author

barisgit commented Sep 9, 2025

I accidentally continued to work right on top of this branch, so unless you pushed something it should be good.

@jbtronics
Copy link
Copy Markdown
Member

Became obsolete by merge of #982

@jbtronics jbtronics closed this Sep 21, 2025
@barisgit barisgit deleted the feature/add-xlsx-support branch September 28, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants