Skip to content

Commit 09a60ee

Browse files
committed
Warn about incomplete EFCore persistence implementations
1 parent 0461db0 commit 09a60ee

2 files changed

Lines changed: 20 additions & 4 deletions

File tree

src/ServiceControl.Persistence.EFCore.PostgreSql/PostgreSqlPersistenceConfiguration.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
11
namespace ServiceControl.Persistence.EFCore.PostgreSql;
22

3+
using Microsoft.Extensions.Logging;
4+
using ServiceControl.Infrastructure;
35
using ServiceControl.Persistence.EFCore.Abstractions;
46

57
class PostgreSqlPersistenceConfiguration : EFPersistenceConfigurationBase
68
{
7-
public override IPersistence Create(PersistenceSettings settings) =>
8-
new PostgreSqlPersistence((PostgreSqlPersisterSettings)settings);
9+
public override IPersistence Create(PersistenceSettings settings)
10+
{
11+
// Temporary until the persister is fully implemented
12+
LoggerUtil.CreateStaticLogger<PostgreSqlPersistenceConfiguration>()
13+
.LogError("The PostgreSQL persistence is still under development and is not ready for use");
14+
15+
return new PostgreSqlPersistence((PostgreSqlPersisterSettings)settings);
16+
}
917

1018
protected override EFPersisterSettings CreateSettings(string connectionString) =>
1119
new PostgreSqlPersisterSettings { ConnectionString = connectionString };

src/ServiceControl.Persistence.EFCore.SqlServer/SqlServerPersistenceConfiguration.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
11
namespace ServiceControl.Persistence.EFCore.SqlServer;
22

3+
using Microsoft.Extensions.Logging;
4+
using ServiceControl.Infrastructure;
35
using ServiceControl.Persistence.EFCore.Abstractions;
46

57
class SqlServerPersistenceConfiguration : EFPersistenceConfigurationBase
68
{
7-
public override IPersistence Create(PersistenceSettings settings) =>
8-
new SqlServerPersistence((SqlServerPersisterSettings)settings);
9+
public override IPersistence Create(PersistenceSettings settings)
10+
{
11+
// Temporary until the persister is fully implemented
12+
LoggerUtil.CreateStaticLogger<SqlServerPersistenceConfiguration>()
13+
.LogError("The SQL Server persistence is still under development and is not ready for use");
14+
15+
return new SqlServerPersistence((SqlServerPersisterSettings)settings);
16+
}
917

1018
protected override EFPersisterSettings CreateSettings(string connectionString) =>
1119
new SqlServerPersisterSettings { ConnectionString = connectionString };

0 commit comments

Comments
 (0)