Remove unneeded tests that test which permissions certain role have.

Author: ramonsmits

src/ServiceControl.AcceptanceTests/Security/OpenIdConnect/When_my_routes_are_requested.cs

@@ -63,48 +63,5 @@ public async Task Should_reject_requests_without_bearer_token()
         OpenIdConnectAssertions.AssertUnauthorized(response);
     }
 
-    [Test]
-    public async Task Reader_can_view_but_cannot_retry()
-    {
-        var routes = await GetRoutes(RolePermissions.Reader);
-
-        using (Assert.EnterMultipleScope())
-        {
-            Assert.That(routes.Any(r => r.UrlTemplate == "/api/configuration"), Is.True,
-                "reader holds :view permissions, so view routes are allowed");
-            Assert.That(routes.Any(r => r.Method == "POST" && r.UrlTemplate.EndsWith("/retry")), Is.False,
-                "reader has no retry permission, so retry routes are excluded");
-        }
-    }
-
-    [Test]
-    public async Task Writer_can_retry()
-    {
-        var routes = await GetRoutes(RolePermissions.Writer);
-
-        Assert.That(routes.Any(r => r.Method == "POST" && r.UrlTemplate.EndsWith("/retry")), Is.True,
-            "writer holds the operate permissions, so retry routes are allowed");
-    }
-
-    async Task<List<RouteManifestEntry>> GetRoutes(string role)
-    {
-        HttpResponseMessage response = null;
-
-        _ = await Define<Context>()
-            .Done(async ctx =>
-            {
-                var token = mockOidcServer.GenerateToken(additionalClaims: [new Claim("roles", role)]);
-                response = await OpenIdConnectAssertions.SendRequestWithBearerToken(
-                    HttpClient, HttpMethod.Get, "/api/my/routes", token);
-                return response != null;
-            })
-            .Run();
-
-        OpenIdConnectAssertions.AssertAuthenticated(response);
-
-        var content = await response.Content.ReadAsStringAsync();
-        return JsonSerializer.Deserialize<List<RouteManifestEntry>>(content, SerializerOptions);
-    }
-
     class Context : ScenarioContext;
 }

src/ServiceControl.Infrastructure.Tests/Auth/EffectivePermissionsTests.cs

@@ -19,54 +19,4 @@ public void Every_permission_is_assigned_to_a_role()
         Assert.That(unassigned, Is.Empty,
             $"Every permission constant must be assigned to a role group in RolePermissions. Unassigned: [{string.Join(", ", unassigned)}]");
     }
-
-    [Test]
-    public void Admin_is_a_proper_superset_of_the_other_roles()
-    {
-        var reader = RolePermissions.Roles[RolePermissions.Reader];
-        var writer = RolePermissions.Roles[RolePermissions.Writer];
-        var admin = RolePermissions.Roles[RolePermissions.Admin];
-
-        using (Assert.EnterMultipleScope())
-        {
-            Assert.That(reader.IsProperSubsetOf(admin), Is.True, "reader must be a proper subset of admin");
-            Assert.That(writer.IsProperSubsetOf(admin), Is.True, "writer must be a proper subset of admin");
-        }
-    }
-
-    [Test]
-    public void Writer_has_no_access_to_configuration_areas()
-    {
-        var writer = RolePermissions.Roles[RolePermissions.Writer];
-
-        string[] configurationAreaPermissions =
-        [
-            Permissions.ErrorLicensingView,
-            Permissions.ErrorLicensingManage,
-            Permissions.ErrorNotificationsView,
-            Permissions.ErrorNotificationsManage,
-            Permissions.ErrorNotificationsTest,
-            Permissions.ErrorRedirectsView,
-            Permissions.ErrorRedirectsManage,
-            Permissions.ErrorThroughputView,
-            Permissions.ErrorThroughputManage,
-        ];
-
-        var granted = configurationAreaPermissions.Where(writer.Contains).ToArray();
-
-        Assert.That(granted, Is.Empty,
-            $"Writer must not hold licensing/notifications/redirects/throughput permissions. Granted: [{string.Join(", ", granted)}]");
-    }
-
-    [Test]
-    public void Role_sets_contain_only_known_permissions()
-    {
-        foreach (var (role, granted) in RolePermissions.Roles)
-        {
-            var unknown = granted.Except(Permissions.All).Order().ToArray();
-
-            Assert.That(unknown, Is.Empty,
-                $"Role '{role}' grants permissions that are not declared on Permissions: [{string.Join(", ", unknown)}]");
-        }
-    }
 }