Make logging provider parsing robust to missing/invalid config#5546
Open
ramonsmits wants to merge 1 commit into
Open
Make logging provider parsing robust to missing/invalid config#5546ramonsmits wants to merge 1 commit into
ramonsmits wants to merge 1 commit into
Conversation
…/invalid config Replace the string `Contains` checks with parsing the `LoggingProviders` config value into the `Loggers` flags enum. Splitting with `RemoveEmptyEntries | TrimEntries` and parsing via `Enum.TryParse` (ignore case, unknown values fall back to `Loggers.None`) keeps the historical "missing/blank/unknown config -> default to NLog" behavior instead of throwing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
LoggingSettingsto parse theLoggingProvidersconfig value into the typedLoggersflags enum instead of doing raw stringContainschecks.Notes
NLog,Seq,Otlp); now also tolerant of surrounding whitespace and casing.