Skip to content

Setup project tweaks #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamararivera merged 3 commits into from
Jul 23, 2026
Merged

Setup project tweaks #1692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26bb27a
Move Setup file into Installer folder
bording Jul 23, 2026
8b1549d
Remove ServiceInsight reference from Setup project
bording Jul 23, 2026
f2c05f6
Use dotnet build to build Setup
bording Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Build Windows installer
env:
AZURE_KEY_VAULT_CLIENT_SECRET: ${{ secrets.AZURE_KEY_VAULT_CLIENT_SECRET }}
run: msbuild src/Setup -p:Configuration=Release -restore -m
run: dotnet build src/Setup --configuration Release
- name: Publish artifacts
uses: actions/upload-artifact@v7.0.1
with:
Expand Down
3 changes: 3 additions & 0 deletions src/ServiceInsight.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<Solution>
<Folder Name="/Installer/">
<File Path="Setup/Setup.csproj" />
</Folder>
<Folder Name="/Solution Items/">
<File Path="Custom.Build.props" />
<File Path="Setup/Setup.csproj" />
Expand Down
4 changes: 0 additions & 4 deletions src/Setup/Setup.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
<TargetFramework>net48</TargetFramework>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\ServiceInsight\ServiceInsight.csproj" />
</ItemGroup>

<Target Name="CreateInstaller" AfterTargets="Build">
<PropertyGroup>
<AdvancedInstallerPath>$(registry:HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Caphyon\Advanced Installer@Advanced Installer Path)</AdvancedInstallerPath>
Expand Down
Loading