Refactoring code to be more component base#2659
Merged
Merged
Conversation
johnsimons
force-pushed
the
john/commonality
branch
from
55a166e to
60ef330
Compare
PhilBastian
approved these changes
Oct 17, 2025
PhilBastian
left a comment
PhilBastian
left a comment
Contributor
There was a problem hiding this comment.
I haven't smoke tested all scenarios, but it looks like a solid refactor
| @@ -0,0 +1,104 @@ | |||
| <script setup lang="ts"> | |||
Contributor
There was a problem hiding this comment.
based on the usages I see, I think this would be better named IconButton
| Last retried: | ||
| <time-since :date-utc="group.last_operation_completion_time"></time-since> | ||
| </span> | ||
| <MetadataItem :icon="faArrowRotateRight"> Last retried: <time-since :date-utc="group.last_operation_completion_time"></time-since> </MetadataItem> |
Contributor
There was a problem hiding this comment.
I can't immediately see why, but the metadata items above (that haven't changed, should they be MetadataItem's?) are no longer showing on this branch
Contributor
There was a problem hiding this comment.
oh, it's because you are no longer importing FAIcon
Member
Author
There was a problem hiding this comment.
Sorry, I am not following? So is there an issue here?
Contributor
There was a problem hiding this comment.
yes, the icons are not showing for the first three metadata items
Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>
johnsimons
force-pushed
the
john/commonality
branch
from
a67a9b9 to
50824df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses: