-
Notifications
You must be signed in to change notification settings - Fork 27
display for license metadata #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PhilBastian
wants to merge
36
commits into
master
Choose a base branch
from
licensed_endpoints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 31 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
d889210
introduce `Licensed Endpoints` tab and migrate controls from internal…
PhilBastian 32f3cf3
migrate endpoint throughput graph logic
PhilBastian d342ae0
make throughput graph points larger to make hovering easier
PhilBastian 048d4ee
change hidden feature toggle combo to something that isn't likely to …
PhilBastian a38e05e
include endpoint size calculations
PhilBastian 28518ee
introduce second level of navigation for non-endpoint queues
PhilBastian cd68a5a
extract data fetch to a store and implement infrastructure/excluded q…
PhilBastian 8576f68
- rename monthly throughput
PhilBastian f4b9fcb
adjust layout to flex
PhilBastian 18c4f3c
rearrange layout
PhilBastian 98d6e7f
include licensed size comparisons
PhilBastian 291e52a
extra collapsed header details
PhilBastian 9e16d67
default to collapsed
PhilBastian f9544eb
make main endpoint paging sticky so that it's visible when all endpoi…
PhilBastian 85aa1e0
change detail order for better association
PhilBastian caf930a
display warning on navigation controls when license is potentially in…
PhilBastian dcbe4b7
read details from licensedetails API
PhilBastian 70f6fc8
handle upload of metadata file
PhilBastian 169f041
validate endpoint metadata id and licenseid match
PhilBastian f11a7d2
unify detail row (label: text) display
PhilBastian f1dcabd
onyl show license details tab when it's possible to be supported
PhilBastian 6494b8b
fix license edition check
PhilBastian d085215
fix tests
PhilBastian 5b59c2f
update local anchor to button for visibility
PhilBastian 31df3a0
update button styles to fit designspace better
PhilBastian 42206bc
set actual page sizes
PhilBastian 2b6b2ec
Merge branch 'master' into licensed_endpoints
PhilBastian cc1993d
potential link off to pricing estimate
PhilBastian f4660f5
make linter happy
PhilBastian 9c3334e
more lint issues
PhilBastian ebf577e
fix test after change from link to button
PhilBastian f1fe652
- compare on scope_hash instead of scope
PhilBastian 50476ac
handle sendonly endpoint size
PhilBastian 6371d48
ensure displayed months don't go 1 higher than expected at the end of…
PhilBastian 90082b3
fixes after review
PhilBastian e1b6ee2
make license details display dependent on presence of has endpoint me…
PhilBastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |
| } | ||
|
|
||
| .pagination { | ||
| margin: 1.5em; | ||
| margin: 1.5rem; | ||
| } | ||
|
|
||
| .pagination > li > button:hover, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <script setup lang="ts"> | ||
| defineProps<{ label: string; tooltip?: string; ariaLabel?: string }>(); | ||
| </script> | ||
|
|
||
| <template> | ||
| <div class="details-item"> | ||
| <label>{{ label }}</label> | ||
| <!-- role and aria-label are used for tests --> | ||
| <span role="note" :title="tooltip" :aria-label="ariaLabel"><slot></slot></span> | ||
| </div> | ||
| </template> | ||
|
|
||
| <style scoped> | ||
| .details-item { | ||
| display: grid; | ||
| gap: 1rem; | ||
| grid-template-columns: 1fr 1fr; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .details-item label { | ||
| font-weight: bold; | ||
| margin: 0; | ||
| } | ||
|
|
||
| .details-item label::after { | ||
| content: ":"; | ||
| } | ||
|
|
||
| .details-item span { | ||
| padding: 0.375rem 0; | ||
| } | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.