#813 Fixed small bug and removed old code

Author: bogadisa

src/backend_data_retrieval/data_retrieval_app/external_data_retrieval/data_retrieval/currency_api_handler.py

@@ -8,19 +8,6 @@ class CurrencyAPIHandler:
     def __init__(self, url: str) -> None:
         self.url = url
 
-    def _combine_currency_data(self, currencies: list, currency_details: list) -> list:
-        """
-        Combines the currency data.
-        """
-        currencies_df = self._json_to_df(currencies)
-        currency_details_df = self._json_to_df(currency_details)
-
-        combined_currency_data_df = currencies_df.merge(
-            currency_details_df,
-            on="id",
-        )
-        return combined_currency_data_df
-
     def _json_to_df(self, currencies: list) -> pd.DataFrame:
         df = pd.json_normalize(currencies)
 

src/backend_data_retrieval/data_retrieval_app/external_data_retrieval/transforming_data/transform_currency_api_data.py

@@ -77,17 +77,17 @@ def _transform_currency_table(
             currency_df["divine.chaosValue"],
         )
 
-        currency_df["tradeName"] = currency_df["name"].map(
-            lambda name: self.name_to_trade_name.get(name, pd.NA)
-        )
-
         chaos_dict = {
             "name": ["Chaos Orb"],
             "chaos.chaosValue": [1],
         }
         chaos_df = pd.DataFrame.from_dict(chaos_dict)
         currency_df = pd.concat((currency_df, chaos_df), ignore_index=True)
 
+        currency_df["tradeName"] = currency_df["name"].map(
+            lambda name: self.name_to_trade_name.get(name, pd.NA)
+        )
+
         currency_df["createdHoursSinceLaunch"] = hours_since_launch
         return currency_df