Skip to content

Commit 05ead08

Browse files
committed
Fix comparison power report tooltip crash caused by lack of passive skill effect
1 parent 14266cc commit 05ead08

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

src/Classes/ComparePowerReportListControl.lua

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,12 @@ function ComparePowerReportListClass:AddValueTooltip(tooltip, index, entry)
127127
if tooltip:CheckForUpdate(node, IsKeyDown("SHIFT"), launch.devModeAlt, build.outputRevision) then
128128
local viewer = build.treeTab and build.treeTab.viewer
129129
if viewer then
130-
viewer:AddNodeTooltip(tooltip, node, build)
130+
-- calculate inc from SmallPassiveSkillEffect
131+
local incSmallPassiveSkillEffect = 0
132+
for _, node in pairs(build.treeTab.build.spec.allocNodes) do
133+
incSmallPassiveSkillEffect = incSmallPassiveSkillEffect + node.modList:Sum("INC", nil ,"SmallPassiveSkillEffect")
134+
end
135+
viewer:AddNodeTooltip(tooltip, node, build, incSmallPassiveSkillEffect)
131136
end
132137
end
133138
else

src/Classes/PassiveMasteryControl.lua

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,12 @@ function PassiveMasteryControlClass:AddValueTooltip(tooltip, index, effect)
3939
self.node.sd = self.treeTab.build.spec.tree.masteryEffects[effect.id].sd
4040
self.node.allMasteryOptions = false
4141
self.treeTab.build.spec.tree:ProcessStats(self.node)
42-
self.treeView:AddNodeTooltip(tooltip, self.node, self.treeTab.build)
42+
-- calculate inc from SmallPassiveSkillEffect
43+
local incSmallPassiveSkillEffect = 0
44+
for _, node in pairs(self.treeTab.build.spec.allocNodes) do
45+
incSmallPassiveSkillEffect = incSmallPassiveSkillEffect + node.modList:Sum("INC", nil ,"SmallPassiveSkillEffect")
46+
end
47+
self.treeView:AddNodeTooltip(tooltip, self.node, self.treeTab.build, incSmallPassiveSkillEffect)
4348
end
4449

4550
function PassiveMasteryControlClass:OnSelClick(index, mastery, doubleClick)

0 commit comments

Comments
 (0)