Fix tests

Author: vaisest

spec/System/TestTradeQueryCurrency_spec.lua

@@ -23,24 +23,6 @@ describe("TradeQuery Currency Conversion", function()
 		end)
 	end)
 
-	describe("ReduceOutput", function()
-		it("uses selected minion stats for weighted result comparison", function()
-			mock_tradeQuery.statSortSelectionList = { { stat = "AverageDamage" } }
-
-			local result = mock_tradeQuery:ReduceOutput({
-				AverageDamage = 10,
-				Life = 100,
-				Minion = {
-					AverageDamage = 250,
-					Life = 200,
-				},
-			})
-
-			assert.are.equals(250, result.AverageDamage)
-			assert.is_nil(result.Life)
-		end)
-	end)
-
 	describe("PriceBuilderProcessPoENinjaResponse", function()
 		-- Pass: Processes without error, restoring map while adding a notice
 		-- Fail: Corrupts map or crashes, indicating fragile API response handling, breaking future conversions

spec/System/TestTradeQueryGenerator_spec.lua

@@ -35,18 +35,31 @@ describe("TradeQueryGenerator", function()
 			assert.are.equal(result, 100)
 		end)
 
-		it("uses minion output for non-FullDPS stats when minion output is available", function()
-			local baseOutput = { AverageDamage = 10, Minion = { AverageDamage = 100 } }
-			local newOutput = { AverageDamage = 10, Minion = { AverageDamage = 250 } }
-			local statWeights = { { stat = "AverageDamage", weightMult = 1 } }
+		it("uses minion output for non-FullDPS stats when minion output is desired", function()
+			local baseOutput = { Life = 10, Minion = { Life = 100 } }
+			local newOutput = { Life = 10, Minion = { Life = 250 } }
+			local statWeights = { { stat = "MinionLife", weightMult = 1 } }
 			data.misc.maxStatIncrease = 1000
 
 			local result = mock_queryGen.WeightedRatioOutputs(baseOutput, newOutput, statWeights)
 
 			assert.are.equal(result, 2.5)
 		end)
 
-		it("uses player output for FullDPS even when minion output is available", function()
+		it("uses lower is better stats correctly", function()
+			local baseOutput = { MaxHit = 100 }
+			local newOutput = { MaxHit = 10 }
+			local statWeights = { { stat = "MaxHit", weightMult = 1, transform = function(number) return -number end } }
+			data.misc.maxStatIncrease = 1000
+
+			local result = mock_queryGen.WeightedRatioOutputs(baseOutput, newOutput, statWeights)
+
+			local close_enough = (result - -0.1) < 0.0001
+			assert.True(close_enough)
+		end)
+
+		it("uses player and minion output for FullDPS", function()
+			-- minion output gets assigned to the player's full dps in reality
 			local baseOutput = { FullDPS = 100, Minion = { FullDPS = 100 } }
 			local newOutput = { FullDPS = 250, Minion = { FullDPS = 1000 } }
 			local statWeights = { { stat = "FullDPS", weightMult = 1 } }
@@ -57,6 +70,16 @@ describe("TradeQueryGenerator", function()
 			assert.are.equal(result, 2.5)
 		end)
 
+		it("uses player output for non-FullDPS even when minion output is available", function()
+			local baseOutput = { Life = 100, Minion = { Life = 100 } }
+			local newOutput = { Life = 250, Minion = { Life = 1000 } }
+			local statWeights = { { stat = "Life", weightMult = 1 } }
+			data.misc.maxStatIncrease = 1000
+
+			local result = mock_queryGen.WeightedRatioOutputs(baseOutput, newOutput, statWeights)
+			assert.are.equal(result, 2.5)
+		end)
+
 		it("uses the fallback DPS ratio once when FullDPS is unavailable", function()
 			local baseOutput = { Minion = { TotalDPS = 10, TotalDotDPS = 0, CombinedDPS = 10 } }
 			local newOutput = { Minion = { TotalDPS = 25, TotalDotDPS = 0, CombinedDPS = 25 } }

spec/System/TestTradeQuery_spec.lua

@@ -0,0 +1,25 @@
+describe("TradeQuery", function ()
+	local mock_tradeQuery
+
+	before_each(function()
+		mock_tradeQuery = new("TradeQuery", { itemsTab = {} })
+	end)
+
+	describe("ReduceOutput", function()
+		it("uses selected minion stats for weighted result comparison", function()
+			mock_tradeQuery.statSortSelectionList = { { stat = "AverageDamage" } }
+
+			local result = mock_tradeQuery:ReduceOutput({
+				AverageDamage = 10,
+				Life = 100,
+				Minion = {
+					AverageDamage = 250,
+					Life = 200,
+				},
+			})
+
+			assert.are.equals(260, result.AverageDamage)
+			assert.is_nil(result.Life)
+		end)
+	end)
+end)