Merge branch 'dev' into copy-augment-socket-bound

Author: vaisest

CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## [v0.21.0](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/tree/v0.21.0) (2026/06/13)
+
+[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/compare/v0.20.0...v0.21.0)
+
+
+## What's Changed
+### New to Path of Building
+- Add 0.5.2 Passive tree changes [\#2162](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2162) ([trompetin17](https://github.com/justjuangui))
+- Add support for very large time-lost jewel mod [\#2182](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2182) ([vaisest](https://github.com/vaisest))
+### User Interface
+- Fix window title changing in compare tab [\#2179](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2179) ([vaisest](https://github.com/vaisest))
+### Fixed Calculations
+- Fix many supports not adding cooldown [\#2185](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2185) ([Peechey](https://github.com/Peechey))
+- Fix calculation of inverted Resistances when having a source of Penetration [\#2177](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2177) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Discipline not being converted by Eldritch Battery [\#2172](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2172) ([LocalIdentity](https://github.com/LocalIdentity))
+### Fixed Behaviours
+- Fix Split Personality not working with Monk and Druid starting points [\#2171](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2171) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix mods duplicating when crafting some Crossbows [\#2173](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2173) ([LocalIdentity](https://github.com/LocalIdentity))
+- Fix Full DPS breakdown and gem dropdowns showing the wrong name for Companion / Spectre skills [\#2160](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2160) ([ltogniolli](https://github.com/ltogniolli))
+- Fix PoB Trader search not working correctly after comparing a build [\#2180](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2180) ([vaisest](https://github.com/vaisest))
+- Fix Mageblood mods merging in item crafter [\#2186](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/pull/2186) ([LocalIdentity](https://github.com/LocalIdentity))
+
+
+
 ## [v0.20.0](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/tree/v0.20.0) (2026/06/11)
 
 [Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/compare/v0.19.0...v0.20.0)

changelog.txt

@@ -1,3 +1,25 @@
+VERSION[0.21.0][2026/06/13]
+
+--- New to Path of Building ---
+* Add 0.5.2 Passive tree changes (trompetin17)
+* Add support for very large time-lost jewel mod (vaisest)
+
+--- User Interface ---
+* Fix window title changing in compare tab (vaisest)
+
+--- Fixed Calculations ---
+* Fix many supports not adding cooldown (Peechey)
+* Fix calculation of inverted Resistances when having a source of Penetration (LocalIdentity)
+* Fix Discipline not being converted by Eldritch Battery (LocalIdentity)
+
+--- Fixed Behaviours ---
+* Fix Split Personality not working with Monk and Druid starting points (LocalIdentity)
+* Fix mods duplicating when crafting some Crossbows (LocalIdentity)
+* Fix Full DPS breakdown and gem dropdowns showing the wrong name for Companion / Spectre skills (ltogniolli)
+* Fix PoB Trader search not working correctly after comparing a build (vaisest)
+* Fix Mageblood mods merging in item crafter (LocalIdentity)
+
+
 VERSION[0.20.0][2026/06/11]
 
 --- New to Path of Building ---

manifest.xml

@@ -30,6 +30,25 @@ describe("TestDefence", function()
 		return build.calcsTab.calcs.reducePoolsByDamage(nil, takenDamages, build.calcsTab.calcsEnv.player)
 	end
 
+	it("converts total energy shield modifiers to mana", function()
+		build.configTab.input.customMods = "Convert 100% of maximum Energy Shield to maximum Mana\n100% increased maximum Mana"
+		build.configTab:BuildModList()
+		runCallback("OnFrame")
+
+		local manaWithoutTotalEnergyShield = build.calcsTab.mainOutput.Mana
+		local env = build.calcsTab.mainEnv
+		local player = env.player
+
+		player.modDB:NewMod("EnergyShieldTotal", "BASE", 100, "Test")
+		player.output = { }
+		build.calcsTab.calcs.defence(env, player)
+
+		assert.are.equals(0, player.output.EnergyShield)
+		assert.are.equals(0, player.modDB:Sum("BASE", nil, "ExtraMana"))
+		assert.are.equals(100, player.modDB:Sum("BASE", nil, "ManaTotal"))
+		assert.are.equals(manaWithoutTotalEnergyShield + 100, player.output.Mana)
+	end)
+
 	it("no armour max hits", function()
 		build.configTab.input.enemyIsBoss = "None"
 		build.configTab.input.customMods = ""

spec/System/TestDefence_spec.lua

@@ -47,17 +47,18 @@ describe("ImportTab", function()
 	it("imports Split Personality alternate class start from character JSON", function()
 		local spec = build.spec
 		local socketNode = spec.nodes[60735]
-		local rangerStartPassive = spec.nodes[56651]
+		local templarStartPassive = spec.nodes[13855]
 		assert.is_not_nil(socketNode)
-		assert.is_not_nil(rangerStartPassive)
+		assert.is_not_nil(templarStartPassive)
+		assert.is_nil(spec.tree.classNameMap.Templar)
+		assert.are.equals(61525, spec.tree.classStartNodeNameMap.Templar)
 
-		local hashes = { socketNode.id, rangerStartPassive.id }
+		local hashes = { socketNode.id, templarStartPassive.id }
 		for _, pathNode in ipairs(socketNode.path or { }) do
 			table.insert(hashes, pathNode.id)
 		end
 
-		local rangerStart = spec.nodes[spec.tree.classes[spec.tree.classNameMap.Ranger].startNodeId]
-		local importPayload = {
+		build.importTab:ImportPassiveTreeAndJewels({
 			name = "Split Import Test",
 			class = "Witch2",
 			league = "Test",
@@ -73,7 +74,7 @@ describe("ImportTab", function()
 					ilvl = 84,
 					properties = { },
 					explicitMods = {
-						"Can Allocate Passive Skills from the Ranger's starting point",
+						"Can Allocate Passive Skills from the Templar's starting point",
 					},
 				},
 			},
@@ -84,17 +85,14 @@ describe("ImportTab", function()
 				jewel_data = { },
 				quest_stats = { },
 			},
-		}
-
-		build.importTab:ImportPassiveTreeAndJewels(importPayload)
+		})
 
 		local importedSpec = build.spec
 		local importedJewel = build.itemsTab.items[importedSpec.jewels[socketNode.id]]
-		assert.are.equals("Ranger", importedJewel.jewelData.alternateClassStart)
-
-		assert.are.equals(0, importedSpec.nodes[rangerStart.id].pathDist)
-		assert.True(importedSpec.nodes[rangerStartPassive.id].alloc)
-		assert.True(importedSpec.nodes[rangerStartPassive.id].connectedToStart)
+		assert.are.equals("Templar", importedJewel.jewelData.alternateClassStart)
+		assert.are.equals(0, importedSpec.nodes[spec.tree.classStartNodeNameMap.Templar].pathDist)
+		assert.True(importedSpec.nodes[templarStartPassive.id].alloc)
+		assert.True(importedSpec.nodes[templarStartPassive.id].connectedToStart)
 	end)
 end)
 

spec/System/TestImportTab_spec.lua

@@ -7,6 +7,32 @@ describe("TetsItemMods", function()
 		-- newBuild() takes care of resetting everything in setup()
 	end)
 
+	it("shows duplicate selected variants in item tooltips when enabled", function()
+		local item = new("Item", [[
+			Rarity: Unique
+			Mageblood
+			Utility Belt
+			Has Alt Variant: true
+			Selected Variant: 1
+			Selected Alt Variant: 1
+			Allow Duplicate Variants: true
+			Variant: Legacy of Amethyst
+			Implicits: 0
+			{variant:1}Legacy of Amethyst
+		]])
+		local tooltip = new("Tooltip")
+
+		build.itemsTab:AddItemTooltip(tooltip, item)
+
+		local legacyLines = 0
+		for _, line in ipairs(tooltip.lines) do
+			if line.text and line.text:find("Legacy of Amethyst", 1, true) then
+				legacyLines = legacyLines + 1
+			end
+		end
+		assert.are.equals(2, legacyLines)
+	end)
+
 	it("aggregates matching ring item rarity lines before applying ring bonus effect", function()
 		build.configTab.input.customMods = "30% increased bonuses gained from left Equipped Ring"
 		build.configTab:BuildModList()

spec/System/TestItemMods_spec.lua

@@ -85,8 +85,45 @@ describe("TestItemParse", function()
 	--it("Variant name", function()
 	--end)
 
-	--it("variant", function()
-	--end)
+	it("allows duplicate selected variants when enabled", function()
+		local item = new("Item", [[
+			Rarity: Unique
+			Mageblood
+			Utility Belt
+			Has Alt Variant: true
+			Has Alt Variant Two: true
+			Has Alt Variant Three: true
+			Selected Variant: 1
+			Selected Alt Variant: 1
+			Selected Alt Variant Two: 2
+			Selected Alt Variant Three: 2
+			Allow Duplicate Variants: true
+			Variant: Legacy of Amethyst
+			Variant: Legacy of Basalt
+			Implicits: 0
+			{variant:1}Legacy of Amethyst
+			{variant:2}Legacy of Basalt
+		]])
+
+		assert.are.equals(2, item.baseModList:Sum("BASE", nil, "LegacyOfAmethyst"))
+		assert.are.equals(2, item.baseModList:Sum("BASE", nil, "LegacyOfBasalt"))
+	end)
+
+	it("does not duplicate selected variants by default", function()
+		local item = new("Item", [[
+			Rarity: Unique
+			Mageblood
+			Utility Belt
+			Has Alt Variant: true
+			Selected Variant: 1
+			Selected Alt Variant: 1
+			Variant: Legacy of Amethyst
+			Implicits: 0
+			{variant:1}Legacy of Amethyst
+		]])
+
+		assert.are.equals(1, item.baseModList:Sum("BASE", nil, "LegacyOfAmethyst"))
+	end)
 
 	--TODO: Alt variants for POB2
 	--it("Alt Variant", function()
@@ -248,6 +285,62 @@ describe("TestItemParse", function()
 		assert.are.equals("+44 to Spirit", item.explicitModLines[1].line)
 	end)
 
+	it("Crafted affixes matching base implicits stay explicit", function()
+		local item = new("Item", [[
+			Rarity: Rare
+			New Item
+			Gemini Crossbow
+			Crafted: true
+			Prefix: None
+			Prefix: None
+			Prefix: None
+			Suffix: {range:0}AdditionalAmmo1
+			Suffix: None
+			Suffix: None
+			Implicits: 1
+			Loads an additional bolt
+		]])
+
+		item:Craft()
+		assert.are.equals(1, #item.implicitModLines)
+		assert.are.equals("Loads an additional bolt", item.implicitModLines[1].line)
+		assert.are.equals(1, #item.explicitModLines)
+		assert.are.equals("Loads an additional bolt", item.explicitModLines[1].line)
+
+		item.suffixes[1].range = 0.2
+		item:Craft()
+		assert.are.equals(1, #item.implicitModLines)
+		assert.are.equals(1, #item.explicitModLines)
+		assert.are.equals("Loads an additional bolt", item.explicitModLines[1].line)
+	end)
+
+	it("Pasted affixes matching base implicits stay explicit", function()
+		local item = new("Item", [[
+			Item Class: Crossbows
+			Rarity: Rare
+			New Item
+			Gemini Crossbow
+			--------
+			Physical Damage: 28-112
+			Critical Hit Chance: 5.00%
+			Attacks per Second: 1.60
+			Reload Time: 1.10
+			--------
+			Requires: Level 78, 89 Str, 89 Dex
+			--------
+			Item Level: 82
+			--------
+			Loads an additional bolt (implicit)
+			--------
+			Loads an additional bolt
+		]])
+
+		assert.are.equals(1, #item.implicitModLines)
+		assert.are.equals("Loads an additional bolt", item.implicitModLines[1].line)
+		assert.are.equals(1, #item.explicitModLines)
+		assert.are.equals("Loads an additional bolt", item.explicitModLines[1].line)
+	end)
+
 	--TODO: POB2 Leagues?
 	--it("League", function()
 	--end)

spec/System/TestItemParse_spec.lua

@@ -377,6 +377,27 @@ describe("TestSkills", function()
 		end
 	end)
 
+	it("uses selected companion names in skill displays", function()
+		build.skillsTab:PasteSocketGroup("Companion: Lightless Abomination 20/0  1")
+		build.skillsTab:PasteSocketGroup("Companion: Lightless Moray 20/0  1")
+		build.skillsTab.socketGroupList[1].includeInFullDPS = true
+		build.skillsTab.socketGroupList[2].includeInFullDPS = true
+		runCallback("OnFrame")
+
+		local skillNames = { }
+		for _, skill in ipairs(build.calcsTab.mainOutput.SkillDPS) do
+			skillNames[skill.name] = true
+		end
+		assert.is_true(skillNames["Companion: Lightless Abomination"])
+		assert.is_true(skillNames["Companion: Lightless Moray"])
+
+		build:RefreshSkillSelectControls(build.controls, 1, "")
+		assert.are.equals("Companion: Lightless Abomination", build.controls.mainSkill.list[1].label)
+
+		build:RefreshSkillSelectControls(build.controls, 2, "")
+		assert.are.equals("Companion: Lightless Moray", build.controls.mainSkill.list[1].label)
+	end)
+
 	it("Inspiring Ally only mirrors companion damage, not generic minion damage", function()
 		build.itemsTab:CreateDisplayItemFromRaw([[
 			New Item
@@ -798,6 +819,20 @@ describe("TestSkills", function()
 		assert.True(build.calcsTab.mainEnv.enemyDB:Sum("BASE", nil, "FireResist") < fireResistWithoutPotentExposure)
 	end)
 
+	it("averages inverted elemental resistance after penetration", function()
+		build.skillsTab:PasteSocketGroup("Fireball 20/0  1")
+		build.configTab.input.enemyIsBoss = "None"
+		build.configTab.input.enemyFireResist = 50
+		build.configTab.input.customMods = "Hits have 50% chance to treat Enemy Monster Elemental Resistance values as inverted\nDamage Penetrates 50% of Enemy Fire Resistance"
+		build.configTab:BuildModList()
+		runCallback("OnFrame")
+
+		assert.are.equals(1.25, build.calcsTab.calcsOutput.FireEffMult)
+		local breakdownText = table.concat(build.calcsTab.calcsEnv.player.breakdown.FireEffMult, "\n")
+		assert.truthy(breakdownText:match("inverted hit"))
+		assert.truthy(breakdownText:match("weighted average"))
+	end)
+
 	it("Test granted skills with exposure stats make exposure configurable", function()
 		build.skillsTab:PasteSocketGroup("Fireball 20/0  1")
 		local spec = build.spec

spec/System/TestSkills_spec.lua

@@ -326,7 +326,7 @@ function CompareEntryClass:RefreshSkillSelectControls(controls, mainGroup, suffi
 		local explodeSource = activeSkill.activeEffect.srcInstance.explodeSource
 		local explodeSourceName = explodeSource and (explodeSource.name or explodeSource.dn)
 		local colourCoded = explodeSourceName and ("From "..colorCodes[explodeSource.rarity or "NORMAL"]..explodeSourceName)
-		t_insert(controls.mainSkill.list, { val = i, label = colourCoded or activeSkill.activeEffect.grantedEffect.name })
+		t_insert(controls.mainSkill.list, { val = i, label = colourCoded or self.calcsTab.calcs.getActiveSkillDisplayName(activeSkill) })
 	end
 	controls.mainSkill.enabled = #displaySkillList > 1
 	controls.mainSkill.selIndex = mainActiveSkill

src/Classes/CompareEntry.lua

@@ -1310,6 +1310,10 @@ function CompareTabClass:ImportBuild(xmlText, label)
 		t_insert(self.compareEntries, entry)
 		self.activeCompareIndex = #self.compareEntries
 		self:UpdateBuildSelector()
+		-- Restore primary build's window title
+		if self.primaryBuild.spec then
+			self.primaryBuild.spec:SetWindowTitleWithBuildClass()
+		end
 		return true
 	end
 	return false